Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Run 'dep init' to create Gopkg.{toml,lock} #6

Closed
wants to merge 2 commits into from

Conversation

sttts
Copy link
Contributor

@sttts sttts commented Dec 9, 2017

Golang/dep does not support picking up these dependencies yet properly. But at least
dep will warn the user when he chooses incompatible dependencies (so did @munnerz report, but with dep init --gopath I did not even get warnings, but it picked up master which it shouldn't).

A test run was published to https://github.com/kubernetes-dep-experiment/client-go

The goal is to vendor k8s.io/client-go, api, apimachinery and all other direct and transistive dependencies of client-go in the versions that are specified in https://github.com/kubernetes-dep-experiment/client-go's Gopkg.{toml,lock} with only specifying the right branch or tag of client-go, i.e.

[[constraint]]
  name = "k8s.io/client-go"
  version = "5.0.1"

For testing purposes one has to define the source for client-go, api and apimachinery to be in the kubernetes-dep-experiment org:

[[constraint]]
  name = "k8s.io/client-go"
  version = "5.0.1"
  source = "https://github.com/kubernetes-dep-experiment/client-go.git"

[[constraint]]
  name = "k8s.io/api"
  source = "https://github.com/kubernetes-dep-experiment/api.git"

[[constraint]]
  name = "k8s.io/apimachinery"
  source = "https://github.com/kubernetes-dep-experiment/apimachinery.git"

Compare https://github.com/sttts/kube-dep-test/blob/master/Gopkg.toml for a test project.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 9, 2017
@sttts
Copy link
Contributor Author

sttts commented Dec 9, 2017

/cc @carolynvs @munnerz

@k8s-ci-robot
Copy link
Contributor

@sttts: GitHub didn't allow me to request PR reviews from the following users: carolynvs.

Note that only kubernetes members can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @carolynvs @munnerz

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sttts
Copy link
Contributor Author

sttts commented Dec 9, 2017

/cc @sdboyer

@k8s-ci-robot
Copy link
Contributor

@sttts: GitHub didn't allow me to request PR reviews from the following users: sdboyer.

Note that only kubernetes members can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @sdboyer

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sdboyer
Copy link

sdboyer commented Dec 15, 2017

so did @munnerz report, but with dep init --gopath I did not even get warnings, but it picked up master which it shouldn't

wait, this sounds like a dep bug? is the "report" you're referring to an issue that was filed? i don't recall seeing one, though i haven't been as diligent as usual this week.

@sttts
Copy link
Contributor Author

sttts commented Dec 19, 2017

wait, this sounds like a dep bug? is the "report" you're referring to an issue that was filed? i don't recall seeing one, though i haven't been as diligent as usual this week.

I believe that was only a quick test with https://github.com/kubernetes-dep-experiment/client-go. Don't know that we have an issue for that, probably not.

@munnerz can you comment?

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 19, 2018
@sttts
Copy link
Contributor Author

sttts commented Mar 19, 2018

Possibly a simple route: #55

@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten
/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Apr 18, 2018
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants