Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency update - Golang 1.21.5/1.20.12 #3383

Closed
29 tasks done
xmudrii opened this issue Nov 30, 2023 · 5 comments
Closed
29 tasks done

Dependency update - Golang 1.21.5/1.20.12 #3383

xmudrii opened this issue Nov 30, 2023 · 5 comments
Assignees
Labels
area/dependency Issues or PRs related to dependency changes area/release-eng Issues or PRs related to the Release Engineering subproject kind/feature Categorizes issue or PR as related to a new feature. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. sig/release Categorizes an issue or PR as relevant to SIG Release.

Comments

@xmudrii
Copy link
Member

xmudrii commented Nov 30, 2023

Tracking info

Link to any previous tracking issue: #3347

Golang mailing list announcement: https://groups.google.com/g/golang-announce/c/TABUsV4-FiU/m/cajfhO09AgAJ

SIG Release Slack thread: https://kubernetes.slack.com/archives/CJH2GBF7Y/p1701369936664499

Work items

After kube-cross image promotion

Note
This update may require an update to go.sum files, for example: kubernetes/kubernetes#118507
This will require an API Review approval.

After go-runner image promotion

After distroless-iptables image promotion

After kubernetes/kubernetes (master) has been updated

Cherry picks

After kubernetes/kubernetes (release branches) has been updated

Follow-up items

/assign
cc: @kubernetes/release-engineering

@xmudrii xmudrii added kind/feature Categorizes issue or PR as related to a new feature. sig/release Categorizes an issue or PR as relevant to SIG Release. area/release-eng Issues or PRs related to the Release Engineering subproject area/dependency Issues or PRs related to dependency changes labels Nov 30, 2023
@xmudrii xmudrii added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Nov 30, 2023
@xmudrii xmudrii added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. and removed priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Dec 6, 2023
@saschagrunert
Copy link
Member

@xmudrii is this done?

@xmudrii
Copy link
Member Author

xmudrii commented Dec 13, 2023

@saschagrunert I still need to update the publishing-bot rules (after the code freeze is lifted) and update the template.

@xmudrii
Copy link
Member Author

xmudrii commented Dec 14, 2023

I'm experimenting with other formats for the Golang update template.


Tracking info

Link to any previous tracking issue: #3347

Golang mailing list announcement: https://groups.google.com/g/golang-announce/c/TABUsV4-FiU/m/cajfhO09AgAJ

SIG Release Slack thread: https://kubernetes.slack.com/archives/CJH2GBF7Y/p1701369936664499

Work items

Phase 1 — build images

### Build images
- [x] `kube-cross`, `go-runner`, and `releng-ci` image updates: https://github.com/kubernetes/release/pull/3388
### Promote images
- [x] `kube-cross` image promotion: https://github.com/kubernetes/k8s.io/pull/6153
- [x] `go-runner` image promotion: https://github.com/kubernetes/k8s.io/pull/6154
- [x] `releng-ci` image promotion: https://github.com/kubernetes/k8s.io/pull/6155

Phase 2 (after go-runner promotion) — build distroless-iptables image

- [x] `distroless-iptables` image updates: https://github.com/kubernetes/release/pull/3389
- [x] `distroless-iptables` image promotion: https://github.com/kubernetes/k8s.io/pull/6164

Phase 3 (after distroless-iptables promotion) — update kubernetes/kubernetes (master)

- [x] Update `kubernetes/kubernetes` (`master`): https://github.com/kubernetes/kubernetes/pull/122201
### `kubernetes/kubernetes` update checklist
- [x] Updated `.go-version` file
- [x] Updated kube-cross image
- [x] Updated go-runner image
- [x] Updated distroless-iptables image
- [x] Updated test image
- [x] Updated publishing-bot rules for `master`

Note
This update may require an update to go.sum files, for example: kubernetes/kubernetes#118507
This will require an API Review approval.

Phase 4 (after kubernetes/kubernetes master update) — builder images

- [x] `k8s-cloud-builder` and `k8s-ci-builder` image update: https://github.com/kubernetes/release/pull/3390
- [x] `kubekins`/`krte` image update: https://github.com/kubernetes/test-infra/pull/31387 

Cherry picks

Phase 5 — create cherry-picks for release branches that use a supported Go version

- [x] Kubernetes 1.28: https://github.com/kubernetes/kubernetes/pull/122216
- [x] Kubernetes 1.27: https://github.com/kubernetes/kubernetes/pull/122217
- [x] Kubernetes 1.26: https://github.com/kubernetes/kubernetes/pull/122218

Phase 6 (after mergining cherry-picks)

### Phase 6a (after mergining cherry-picks) — publishing-bot rules
- [x] Update publishing-bot rules in `kubernetes/kubernetes` for release branches: https://github.com/kubernetes/kubernetes/pull/122299
### Phase 6b (after mergining cherry-picks) — builder images
- [x] `k8s-cloud-builder` and `k8s-ci-builder` image update: https://github.com/kubernetes/release/pull/3394
- [x] `kubekins`/`krte` image update: https://github.com/kubernetes/test-infra/pull/31398

Follow-up items

### Follow-up items
- [ ] Ensure the Golang issue template is updated with any new requirements

@xmudrii
Copy link
Member Author

xmudrii commented Dec 15, 2023

All tasks are done. 🎉
/close

@k8s-ci-robot
Copy link
Contributor

@xmudrii: Closing this issue.

In response to this:

All tasks are done. 🎉
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependency Issues or PRs related to dependency changes area/release-eng Issues or PRs related to the Release Engineering subproject kind/feature Categorizes issue or PR as related to a new feature. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. sig/release Categorizes an issue or PR as relevant to SIG Release.
Projects
None yet
Development

No branches or pull requests

3 participants