images: Use OS codenames to construct clearer versions for Debian images #1496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
release-note
k8s-ci-robot
added
do-not-merge/hold
k8s-ci-robot
added
kind/feature
k8s-ci-robot
added
sig/release
Signed-off-by: Stephen Augustus <saugustus@vmware.com>
justaugustus
force-pushed
the
debian-base
branch
from
4a6b261
to
1cf4358
Compare
k8s-ci-robot
added
the
area/release-eng
k8s-ci-robot
added
the
lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, dims, hasheddan, justaugustus, saschagrunert, xmudrii The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Thanks everyone! |
k8s-ci-robot
removed
the
do-not-merge/hold
|
/test pull-release-test |
1 similar comment
|
/test pull-release-test |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup feature design
/area dependency
What this PR does / why we need it:
Currently the Debian base images we build encode no particularly useful information in the image tag, outside of some yet-to-be-defined SemVer versioning.
A rough example would be:
k8s.gcr.io/build-image/debian-base:v2.1.3In this case, the version numbers are meant to mean the following:
2: the v2 instance of these images, which in this case are built on Debian Buster (compared to v1, built on Debian Stretch)1: we bumped the minor version when we migrated the image building to K8s Infra in cleanup: Base image workflow improvements kubernetes#906653: we bump the patch version to trigger a new build when there are negligible changes to the Makefile/DockerfileThis PR sets Debian base image tags to use the following nomenclature:
<os-codename>-v<version>(example:buster-v0.0.0)The first part of the image tag encodes the Debian OS codename e.g.,
buster,stretch, while the second part of the tag is a SemVer-compliant tag (which we can define a policy around at a later date).This has some parallels to the kube-cross image tags (example:
v1.15.0-1), which encodes the upstream Golang version (v1.15.0), alongside an additional tag,-1./hold for any discussion
/assign @tpepper @hasheddan @saschagrunert @cpanato
cc: @kubernetes/release-engineering @dims @BenTheElder
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?