Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

k8s-ci-builder: Clean up image building configs #1710

Merged
merged 4 commits into from
Nov 10, 2020
Merged

k8s-ci-builder: Clean up image building configs #1710

merged 4 commits into from
Nov 10, 2020

Conversation

justaugustus
Copy link
Member

@justaugustus justaugustus commented Nov 10, 2020 •
edited
Loading

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Continuation of #1698 and #1700.

  • k8s-ci-builder: Clean up image building configs
  • pkg/build: s/DockerRegistry/Registry
  • k8s-ci-builder: Copy Dockerfile and utility scripts from krte
  • k8s-ci-builder: Update build args/variants to include krte config

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

- k8s-ci-builder: Clean up image building configs
- pkg/build: s/DockerRegistry/Registry
- k8s-ci-builder: Copy Dockerfile and utility scripts from krte
- k8s-ci-builder: Update build args/variants to include krte config

@justaugustus
k8s-ci-builder: Clean up image building configs
4ff9e77 
Signed-off-by: Stephen Augustus <saugustus@vmware.com>
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 10, 2020
@k8s-ci-robot k8s-ci-robot added area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 10, 2020
@justaugustus justaugustus mentioned this pull request Nov 10, 2020
Merged
@justaugustus
pkg/build: s/DockerRegistry/Registry
b30afc3 
Signed-off-by: Stephen Augustus <saugustus@vmware.com>
@justaugustus
k8s-ci-builder: Copy Dockerfile and utility scripts from krte
6574cdb 
Signed-off-by: Stephen Augustus <saugustus@vmware.com>
@justaugustus
k8s-ci-builder: Update build args/variants to include krte config
d83512a 
Signed-off-by: Stephen Augustus <saugustus@vmware.com>
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Nov 10, 2020
@justaugustus justaugustus changed the title [WIP] k8s-ci-builder: Clean up image building configs k8s-ci-builder: Clean up image building configs Nov 10, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 10, 2020
@justaugustus
Copy link
Member Author

/assign @hasheddan
cc: @kubernetes/release-engineering

@justaugustus
Copy link
Member Author

Successful GCB runs against d83512a:

hasheddan
hasheddan approved these changes Nov 10, 2020
View reviewed changes
Copy link
Contributor

@hasheddan hasheddan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 10, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hasheddan, justaugustus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [hasheddan,justaugustus]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 65be49f into kubernetes:master Nov 10, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Nov 10, 2020
This was referenced Nov 10, 2020
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hasheddan hasheddan hasheddan approved these changes

@dougm dougm Awaiting requested review from dougm

@mkorbi mkorbi Awaiting requested review from mkorbi

Assignees

@hasheddan hasheddan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
v1.20
Development

Successfully merging this pull request may close these issues.
3 participants
@justaugustus @k8s-ci-robot @hasheddan