kube-cross: Build v1.16.5-canary-2 image without etcd #2124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stephen Augustus <foo@auggie.dev>
etcd may not actually be required in our kube-cross image. This canary build will attempt to validate that premise. Signed-off-by: Stephen Augustus <foo@auggie.dev>
k8s-ci-robot
added
the
release-note
k8s-ci-robot
added
kind/cleanup
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justaugustus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
|
/lgtm |
k8s-ci-robot
added
the
lgtm
This was referenced Jun 19, 2021
|
Testing here: kubernetes/kubernetes#104400 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
/area dependency
What this PR does / why we need it:
During a discussion about updating etcd in the kube-cross image (ref: #2123), @liggitt raised a question about whether we even need etcd to be included in this image.
Here we update the kube-cross
canaryvariant to drop etcd./assign @saschagrunert @cpanato @puerco @hasheddan
cc: @kubernetes/release-engineering
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?