-
Notifications
You must be signed in to change notification settings - Fork 497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bash: use k8s-release-dev for CI builds #2158
Conversation
@spiffxp: Adding label: Reasons for blocking this PR:[Changes to push-build.sh will immediately affect the Kubernetes CI. This PR must be explicitly approved by SIG Release repo admins.] Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/uncc @sethmccombs @mkorbi |
Echoing Aaron with an explicit hold for monitoring jobs following the merge of kubernetes/test-infra#22840. FYI @kubernetes/release-engineering @kubernetes/ci-signal @kubernetes/release-team |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, justaugustus, saschagrunert, spiffxp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
/retest
|
https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/ci-kubernetes-e2e-gce-stable1-beta-upgrade-master started failing on the extract step ~4 days ago with this error:
Are there changes required in kubernetes/kubernetes or do we need to backfill marker files to this bucket? |
tracking upgrade test failure in kubernetes/kubernetes#103697 |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Default to community-owned
gs://k8s-release-dev
instead ofgoogle.com-owned
gs://kubernetes-release-dev
for reading andwriting CI builds
Specifically we're modifying the default value for two bash scripts:
push-build.sh
packages/deb/jenkins.sh
Which issue(s) this PR fixes:
This doesn't fix, but is part of:
Special notes for your reviewer:
/hold
I would prefer to see kubernetes/test-infra#22840
merge first, and be able to remove /hold once I'm satisfied and
available to watch over any impact
That updates the deprecated
--scenario=kubernetes_build
jobs such thatthey'll end up explicitly passing
--bucket=kubernetes-release-dev
topush-build.sh
Does this PR introduce a user-facing change?