Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

images: Build bullseye variants (part two) #2210

Merged
merged 4 commits into from
Sep 14, 2021
Merged

images: Build bullseye variants (part two) #2210

merged 4 commits into from
Sep 14, 2021

Conversation

justaugustus
Copy link
Member

@justaugustus justaugustus commented Aug 16, 2021 •
edited
Loading

What type of PR is this?

/kind feature
/area dependency release-eng/security

What this PR does / why we need it:

Continuation of #2209, #2211, and #2223.

  • debian-iptables: Build bullseye-v1.0.0 images
  • images: Build go1.17-bullseye variants
    • go-runner:v2.3.1-go1.17.1-bullseye.0
    • releng-ci

Signed-off-by: Stephen Augustus foo@auggie.dev

/assign @puerco @saschagrunert @cpanato
cc: @kubernetes/release-engineering

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

- debian-iptables: Build bullseye-v1.0.0 images
- images: Build go1.17-bullseye variants
  - go-runner:v2.3.1-go1.17.1-bullseye.0
  - releng-ci

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. area/dependency Issues or PRs related to dependency changes area/release-eng/security Issues or PRs related to release engineering security cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 16, 2021
@k8s-ci-robot k8s-ci-robot added area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 16, 2021
@justaugustus justaugustus mentioned this pull request Aug 16, 2021
Merged
@justaugustus
Copy link
Member Author

justaugustus commented Aug 16, 2021 •
edited
Loading

One more time, to make sure this isn't a flake:
/test pull-release-image-setcap

@justaugustus
Copy link
Member Author

/test pull-release-image-debian-iptables

@justaugustus justaugustus added this to the v1.23 milestone Aug 16, 2021
@justaugustus
Copy link
Member Author

Due to Debian bullseye and Golang 1.17 upstream image updates happening roughly in tandem, the latest image builds shifted to using bullseye, instead of buster by default (ref: #2218).

I'm combining this PR with go1.17 image updates in #2211 to tackle this all at once and minimize the image promotion churn.

/close

@k8s-ci-robot
Copy link
Contributor

@justaugustus: Closed this PR.

In response to this:

Due to Debian bullseye and Golang 1.17 upstream image updates happening roughly in tandem, the latest image builds shifted to using bullseye, instead of buster by default (ref: #2218).

I'm combining this PR with go1.17 image updates in #2211 to tackle this all at once and minimize the image promotion churn.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@justaugustus justaugustus mentioned this pull request Aug 23, 2021
Merged
@justaugustus justaugustus reopened this Aug 24, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justaugustus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 24, 2021
@justaugustus
Copy link
Member Author

/hold to rebase out #2211

@sozercan sozercan mentioned this pull request Aug 25, 2021
Closed
@justaugustus
Copy link
Member Author

/test pull-release-image-kubepkg

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 10, 2021
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 10, 2021
@justaugustus
Copy link
Member Author

/test pull-release-image-k8s-ci-builder
/test pull-release-image-kube-cross
/test pull-release-image-setcap

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Sep 10, 2021 •
edited
Loading

@justaugustus: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Rerun command
pull-release-image-kpromo 34b6f9b link /test pull-release-image-kpromo
pull-release-image-k8s-ci-builder ded9325 link /test pull-release-image-k8s-ci-builder
pull-release-image-kube-cross ded9325 link /test pull-release-image-kube-cross

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@justaugustus justaugustus changed the title images: Build bullseye variants images: Build bullseye variants (part two) Sep 14, 2021
@justaugustus justaugustus mentioned this pull request Sep 14, 2021
Merged
@justaugustus justaugustus marked this pull request as ready for review September 14, 2021 22:12
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 14, 2021
@justaugustus
dependencies.yaml: Update dependents to use debian-base:bullseye-v1.0.0
36a12d0 
Signed-off-by: Stephen Augustus <foo@auggie.dev>
@justaugustus
debian-iptables: Build bullseye-v1.0.0 images
31530bf 
Signed-off-by: Stephen Augustus <foo@auggie.dev>
@justaugustus
debian-iptables(bullseye): Drop package installations from backports
16d5cb0 
iptables and ebtables are at sufficiently recent versions in bullseye
that installing from bullseye-backports should not be necessary.

Signed-off-by: Stephen Augustus <foo@auggie.dev>
@justaugustus
images: Build go1.17-bullseye variants (part one)
a639b11 
- go-runner:v2.3.1-go1.17.1-bullseye.0
- releng-ci

The other image builds are failing and will be addressed in a
follow-up. Namely:
- kube-cross
- k8s-ci-builder

Signed-off-by: Stephen Augustus <foo@auggie.dev>
@justaugustus
Copy link
Member Author

I've dropped the failing images from this PR and will address them in #2249.

/hold cancel
/assign @puerco @cpanato @Verolop @ameukam
cc: @kubernetes/release-engineering

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 14, 2021
@puerco
Copy link
Member

puerco commented Sep 14, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 14, 2021
@Verolop
Copy link
Contributor

Verolop commented Sep 14, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit f50fdab into kubernetes:master Sep 14, 2021
@justaugustus justaugustus mentioned this pull request Sep 15, 2021
Merged
@justaugustus
Copy link
Member Author

Promotion PR: kubernetes/k8s.io#2723

@justaugustus justaugustus mentioned this pull request Sep 21, 2021
Merged
@justaugustus justaugustus mentioned this pull request Nov 10, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpanato cpanato Awaiting requested review from cpanato

@mkumatag mkumatag Awaiting requested review from mkumatag

Assignees

@saschagrunert saschagrunert

@Verolop Verolop

@ameukam ameukam

@puerco puerco

@cpanato cpanato

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes area/release-eng/security Issues or PRs related to release engineering security area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.
7 participants
@justaugustus @k8s-ci-robot @puerco @Verolop @saschagrunert @ameukam @cpanato