Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update distroless-iptables to use go 1.21.3 #3321

Merged
merged 1 commit into from
Oct 12, 2023
Merged

Update distroless-iptables to use go 1.21.3 #3321

merged 1 commit into from
Oct 12, 2023

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Oct 12, 2023

What type of PR is this?

/kind feature

What this PR does / why we need it:

  • Update distroless-iptables to use Go 1.21.3

Which issue(s) this PR fixes:

xref #3311

Does this PR introduce a user-facing change?

Update distroless-iptables to use Go 1.21.3

/assign @saschagrunert @xmudrii @Verolop @puerco
cc @kubernetes/release-engineering

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority area/release-eng Issues or PRs related to the Release Engineering subproject labels Oct 12, 2023
@k8s-ci-robot k8s-ci-robot added sig/release Categorizes an issue or PR as relevant to SIG Release. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 12, 2023
@cpanato cpanato mentioned this pull request Oct 12, 2023
Closed
28 tasks
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 12, 2023
@cpanato
Copy link
Member Author

cpanato commented Oct 12, 2023

fixing the failing test

@cpanato
Update distroless-iptables to use go 1.21.3
e3e6f3d 
Signed-off-by: cpanato <ctadeu@gmail.com>
xmudrii
xmudrii approved these changes Oct 12, 2023
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 12, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 8ffc537 into kubernetes:master Oct 12, 2023
@cpanato cpanato deleted the update-distroless branch October 12, 2023 16:21
@rikatz
Copy link
Contributor

rikatz commented Oct 12, 2023

@cpanato @danwinship just did a new release of distroless-iptables as 0.4.0, and was wondering about image promotion.

Can I assume 0.4.1 is the one to be promoted, as you did merged this PR over his change?

Thanks!!

@rikatz rikatz mentioned this pull request Oct 12, 2023
Merged
@cpanato
Copy link
Member Author

cpanato commented Oct 12, 2023

@cpanato @danwinship just did a new release of distroless-iptables as 0.4.0, and was wondering about image promotion.

Can I assume 0.4.1 is the one to be promoted, as you did merged this PR over his change?

Thanks!!

Yes will be promoted soon :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmudrii xmudrii xmudrii approved these changes

@andrewsykim andrewsykim Awaiting requested review from andrewsykim

@jrsapi jrsapi Awaiting requested review from jrsapi

Assignees

@xmudrii xmudrii

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cpanato @k8s-ci-robot @rikatz @xmudrii