Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-add production bucket fix to release notes index #3838

Merged
merged 1 commit into from
Nov 21, 2024
Merged

Re-add production bucket fix to release notes index #3838

merged 1 commit into from
Nov 21, 2024

Conversation

saschagrunert
Copy link
Member

@saschagrunert saschagrunert commented Nov 21, 2024 •
edited
Loading

What type of PR is this?

/kind bug

What this PR does / why we need it:

The index still contains entries referring to the production bucket after the recent patches:

> curl -sfL https://dl.k8s.io/release/release-notes-index.json | jq . | rg -v dl.k8s.io
{
  "v1.29.11": "gs://767373bbdcb8270361b96548387bf2a9ad0d48758c35/release/v1.29.11/release-notes.json",
  "v1.30.7": "gs://767373bbdcb8270361b96548387bf2a9ad0d48758c35/release/v1.30.7/release-notes.json",
  "v1.31.3": "gs://767373bbdcb8270361b96548387bf2a9ad0d48758c35/release/v1.31.3/release-notes.json",
}

We fix that by slightly modifying the existing function and the tests.

Which issue(s) this PR fixes:

Fixes #3833

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

Fixed release notes index to not refer `gs://` links to the production bucket.

@saschagrunert
Re-add production bucket fix to release notes index
98c41c9 
The index still contains entries referring to the production bucket after the recent patches:

```
> curl -sfL https://dl.k8s.io/release/release-notes-index.json | jq . | rg -v dl.k8s.io
{
  "v1.29.11": "gs://767373bbdcb8270361b96548387bf2a9ad0d48758c35/release/v1.29.11/release-notes.json",
  "v1.30.7": "gs://767373bbdcb8270361b96548387bf2a9ad0d48758c35/release/v1.30.7/release-notes.json",
  "v1.31.3": "gs://767373bbdcb8270361b96548387bf2a9ad0d48758c35/release/v1.31.3/release-notes.json",
}
```

We fix that by slightly modifying the existing function and the tests.

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/release-eng Issues or PRs related to the Release Engineering subproject labels Nov 21, 2024
@k8s-ci-robot k8s-ci-robot added sig/release Categorizes an issue or PR as relevant to SIG Release. needs-priority approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 21, 2024
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 21, 2024
@k8s-ci-robot k8s-ci-robot merged commit b723b17 into kubernetes:master Nov 21, 2024
11 checks passed
@saschagrunert saschagrunert deleted the release-notes-index-fix-2 branch November 21, 2024 08:54
@k8s-ci-robot
Copy link
Contributor

@preechapon-cmd: changing LGTM is restricted to collaborators

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot
Copy link
Contributor

@preechapon-cmd: changing LGTM is restricted to collaborators

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, preechapon-cmd, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@preechapon-cmd preechapon-cmd preechapon-cmd approved these changes

@cpanato cpanato cpanato approved these changes

@jimangel jimangel Awaiting requested review from jimangel

@salaxander salaxander Awaiting requested review from salaxander

Assignees

@cpanato cpanato

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Release Notes Index broken
4 participants
@saschagrunert @k8s-ci-robot @cpanato @preechapon-cmd