-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle multiple CVEs per issue in official CVE feed #117
Handle multiple CVEs per issue in official CVE feed #117
Conversation
Welcome @robert-cronin! |
/hold (Discussing more on possible solutions in linked issue) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few minor comments, I think this is okay to merge once these are addressed. I am also convinced this is the right approach to resolve this, so no issues in terms of revisiting that. Shared more here: kubernetes/website#47003 (comment)
- Modify script to create separate entries for each CVE ID when multiple are present in a single issue
94591f2
to
84bb15a
Compare
@PushkarJ I've gone through and updated the script based on the feedback received. Here's the updated output: Thank you for your suggestions! |
@robert-cronin Thank you so much for your efforts in fixing this and addressing the comments and coming up with even better idea about dictionary copy /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: PushkarJ, robert-cronin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
No problems, happy to help 🙂 |
Fix multiple CVE handling in official CVE feed
Fixes kubernetes/website#47003
This change modifies the script used to generate the CVE feed to correctly handle issues containing multiple CVEs. Key updates:
This approach aims to resolve the malformed GUID issue while preserving the feed's integrity. Feedback and suggestions for improvement are welcome.
Here is the output from before and after the change:
before.txt
after.txt