Merge pull request #5411 from BenTheElder/just-rm-the-tests

enforce no vendored tests in test-infra

hack/update-bazel.sh

@@ -20,6 +20,12 @@ set -o pipefail
 TESTINFRA_ROOT=$(git rev-parse --show-toplevel)
 TMP_GOPATH=$(mktemp -d)
 
+# no unit tests in vendor
+# previously we used godeps which did this, but `dep` does not handle this
+# properly yet. some of these tests don't build well. see:
+# ref: https://github.com/kubernetes/test-infra/pull/5411
+find ${TESTINFRA_ROOT}/vendor/ -name "*_test.go" -delete
+
 "${TESTINFRA_ROOT}/hack/go_install_from_commit.sh" \
   github.com/kubernetes/repo-infra/kazel \
   e26fc85d14a1d3dc25569831acc06919673c545a \

hack/verify-bazel.sh

@@ -45,9 +45,16 @@ kazel_diff=$("${TMP_GOPATH}/bin/kazel" \
   -print-diff \
   -root="${TESTINFRA_ROOT}")
 
-if [[ -n "${gazelle_diff}" || -n "${kazel_diff}" ]]; then
+# check if there are vendor/*_test.go
+# previously we used godeps which did this, but `dep` does not handle this
+# properly yet. some of these tests don't build well. see:
+# ref: https://github.com/kubernetes/test-infra/pull/5411
+vendor_tests=$(find ${TESTINFRA_ROOT}/vendor/ -name "*_test.go" | wc -l)
+
+if [[ -n "${gazelle_diff}" || -n "${kazel_diff}" || "${vendor_tests}" -ne "0" ]]; then
   echo "${gazelle_diff}"
   echo "${kazel_diff}"
+  echo "number of vendor/*_test.go: ${vendor_tests} (want: 0)"
   echo
   echo "Run ./hack/update-bazel.sh"
   exit 1