Skip to content

Commit

Permalink
cluster-api: add a do-not-merge/needs-area label
Browse files Browse the repository at this point in the history
This label will be added automatically when a PR is missing an "area/*"
label in the cluster-api repo, which will block PRs from being merged
until an "area/*" label is added.

Signed-off-by: Michael Shen <mishen@umich.edu>
  • Loading branch information
mjlshen committed Aug 8, 2023
1 parent 9c9d12b commit e323e41
Show file tree
Hide file tree
Showing 4 changed files with 42 additions and 0 deletions.
17 changes: 17 additions & 0 deletions config/prow/config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -772,6 +772,23 @@ tide:
- do-not-merge/work-in-progress
- needs-rebase
- needs-kind
- repos:
- kubernetes-sigs/cluster-api
labels:
- lgtm
- approved
- "cncf-cla: yes"
missingLabels:
- do-not-merge
- do-not-merge/blocked-paths
- do-not-merge/contains-merge-commits
- do-not-merge/hold
- do-not-merge/invalid-commit-message
- do-not-merge/invalid-owners-file
- do-not-merge/needs-area
- do-not-merge/release-note-label-needed
- do-not-merge/work-in-progress
- needs-rebase
merge_method:
kubernetes-client/csharp: squash
kubernetes-client/gen: squash
Expand Down
12 changes: 12 additions & 0 deletions config/prow/plugins.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -855,6 +855,18 @@ require_matching_label:
issues: true
prs: true
regexp: ^priority/
- missing_label: do-not-merge/needs-area
org: kubernetes-sigs
repo: cluster-api
issues: false
prs: true
regexp: ^area/
missing_comment: |
This PR is currently missing an area label, which is used to identify the modified component when generating release notes.
Area labels can be added by org members by writing `/area ${COMPONENT}` in a comment
Please see the [labels list](https://github.com/kubernetes/test-infra/blob/master/label_sync/labels.md#labels-that-apply-to-kubernetes-sigscluster-api-for-both-issues-and-prs) for possible areas.
- missing_label: needs-triage
org: kubernetes-sigs
repo: cluster-api
Expand Down
7 changes: 7 additions & 0 deletions label_sync/labels.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
- [Labels that apply to all repos, only for issues](#labels-that-apply-to-all-repos-only-for-issues)
- [Labels that apply to all repos, only for PRs](#labels-that-apply-to-all-repos-only-for-prs)
- [Labels that apply to kubernetes-sigs/cluster-api, for both issues and PRs](#labels-that-apply-to-kubernetes-sigscluster-api-for-both-issues-and-prs)
- [Labels that apply to kubernetes-sigs/cluster-api, only for PRs](#labels-that-apply-to-kubernetes-sigscluster-api-only-for-prs)
- [Labels that apply to kubernetes-sigs/cluster-api-operator, for both issues and PRs](#labels-that-apply-to-kubernetes-sigscluster-api-operator-for-both-issues-and-prs)
- [Labels that apply to kubernetes-sigs/cluster-api-provider-aws, for both issues and PRs](#labels-that-apply-to-kubernetes-sigscluster-api-provider-aws-for-both-issues-and-prs)
- [Labels that apply to kubernetes-sigs/cluster-api-provider-aws, only for issues](#labels-that-apply-to-kubernetes-sigscluster-api-provider-aws-only-for-issues)
Expand Down Expand Up @@ -223,6 +224,12 @@ larger set of contributors to apply/remove them.
| <a id="kind/proposal" href="#kind/proposal">`kind/proposal`</a> | Issues or PRs related to proposals.| anyone | [label](https://git.k8s.io/test-infra/prow/plugins/label) |
| <a id="kind/release-blocking" href="#kind/release-blocking">`kind/release-blocking`</a> | Issues or PRs that need to be closed before the next CAPI release| approvers | [label](https://git.k8s.io/test-infra/prow/plugins/label) |

## Labels that apply to kubernetes-sigs/cluster-api, only for PRs

| Name | Description | Added By | Prow Plugin |
| ---- | ----------- | -------- | --- |
| <a id="do-not-merge/needs-area" href="#do-not-merge/needs-area">`do-not-merge/needs-area`</a> | PR is missing an area label| prow | [require-matching-label](https://git.k8s.io/test-infra/prow/plugins/require-matching-label) |

## Labels that apply to kubernetes-sigs/cluster-api-operator, for both issues and PRs

| Name | Description | Added By | Prow Plugin |
Expand Down
6 changes: 6 additions & 0 deletions label_sync/labels.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -1878,6 +1878,12 @@ repos:
target: both
prowPlugin: label
addedBy: anyone
- color: e11d21
description: PR is missing an area label
name: do-not-merge/needs-area
target: prs
prowPlugin: require-matching-label
addedBy: prow
kubernetes-sigs/cluster-api-operator:
labels:
- color: c7def8
Expand Down

0 comments on commit e323e41

Please sign in to comment.