add comments to bazel scripts regarding vendor tests

kubernetes · Nov 13, 2017 · f7ec197 · f7ec197
1 parent dccb727
commit f7ec197
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/hack/update-bazel.sh b/hack/update-bazel.sh
@@ -21,6 +21,9 @@ TESTINFRA_ROOT=$(git rev-parse --show-toplevel)
 TMP_GOPATH=$(mktemp -d)
 
 # no unit tests in vendor
+# previously we used godeps which did this, but `dep` does not handle this
+# properly yet. some of these tests don't build well. see:
+# ref: https://github.com/kubernetes/test-infra/pull/5411
 find ${TESTINFRA_ROOT}/vendor/ -name "*_test.go" -delete
 
 "${TESTINFRA_ROOT}/hack/go_install_from_commit.sh" \

diff --git a/hack/verify-bazel.sh b/hack/verify-bazel.sh
@@ -46,12 +46,15 @@ kazel_diff=$("${TMP_GOPATH}/bin/kazel" \
   -root="${TESTINFRA_ROOT}")
 
 # check if there are vendor/*_test.go
+# previously we used godeps which did this, but `dep` does not handle this
+# properly yet. some of these tests don't build well. see:
+# ref: https://github.com/kubernetes/test-infra/pull/5411
 vendor_tests=$(find ${TESTINFRA_ROOT}/vendor/ -name "*_test.go" | wc -l)
 
 if [[ -n "${gazelle_diff}" || -n "${kazel_diff}" || "${vendor_tests}" -ne "0" ]]; then
   echo "${gazelle_diff}"
   echo "${kazel_diff}"
-  echo "number of vendor/*_test.go: ${vendor_tests}"
+  echo "number of vendor/*_test.go: ${vendor_tests} (want: 0)"
   echo
   echo "Run ./hack/update-bazel.sh"
   exit 1