Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gubernator: support logs in nested directories #10289

Closed
pohly opened this issue Nov 30, 2018 · 6 comments
Closed

gubernator: support logs in nested directories #10289

pohly opened this issue Nov 30, 2018 · 6 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@pohly
Copy link
Contributor

pohly commented Nov 30, 2018

What would you like to be added:

When viewing test artifacts via the log view (for example, https://gubernator.k8s.io/build/kubernetes-jenkins/logs/ci-kubernetes-e2e-gci-gce-serial/4398/nodelog), logs are only found if they are one level below the artifacts directory. This works:

  • artifacts/_sig-storage_CSI_Volumes_Driver_csi-hostpath-v0_Testpattern_Dynamic_PV_default_fs_subPath_should_unmount_if_pod_is_force_deleted_while_kubelet_is_down_Disruptive_Slow_/csi-hostpath-attacher-0-csi-attacher.log

This doesn't:

  • artifacts/sig-storage/CSI_Volumes/Driver_csi-hostpath_v0/Testpattern_Dynamic_PV/default_fs_subPath/should_unmount_if_pod_is_force_deleted_while_kubelet_is_down_Disruptive_Slow_/csi-hostpath-attacher-0-csi-attacher.log

What happens when creating such logs is that the UI displays just the top-level directories but not the files inside them.

The simplest solution would be to keep the current grouping in the UI (directory name in bold to group files, underneath each file in that directory with a checkmark) but search more thoroughly for log files and allow nested directories. Then at least looking at the "artifects" directory would become easier.

But users of the log viewer would still see quite a few files they have no interest in. So some UI redesign with nested grouping and deeper groups folded away by default would be needed to address that.

Why is this needed:

These logs for storage tests have proven to be very useful for analysing errors involving the various CSI sidecar containers, see for example kubernetes-csi/external-attacher#102. But other groups now have to skip over a lot of files they have no interest, so moving them to sub-directories and UI enhancements to hide them by default would be useful.

/kind feature
/cc @msau42

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 30, 2018
@BenTheElder
Copy link
Member

this would be a good feature for spyglass @Katharine @ibzib @paulangton

currently gubernator is mostly in maintenance mode.

@Katharine
Copy link
Member

I didn't even know gubernator had this feature.

Another one for the spyglass todo list.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 4, 2019
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Apr 3, 2019
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

@k8s-ci-robot
Copy link
Contributor

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

5 participants