-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gubernator: support logs in nested directories #10289
Comments
this would be a good feature for spyglass @Katharine @ibzib @paulangton currently gubernator is mostly in maintenance mode. |
I didn't even know gubernator had this feature. Another one for the spyglass todo list. |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Rotten issues close after 30d of inactivity. Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
@fejta-bot: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What would you like to be added:
When viewing test artifacts via the log view (for example, https://gubernator.k8s.io/build/kubernetes-jenkins/logs/ci-kubernetes-e2e-gci-gce-serial/4398/nodelog), logs are only found if they are one level below the
artifacts
directory. This works:artifacts/_sig-storage_CSI_Volumes_Driver_csi-hostpath-v0_Testpattern_Dynamic_PV_default_fs_subPath_should_unmount_if_pod_is_force_deleted_while_kubelet_is_down_Disruptive_Slow_/csi-hostpath-attacher-0-csi-attacher.log
This doesn't:
artifacts/sig-storage/CSI_Volumes/Driver_csi-hostpath_v0/Testpattern_Dynamic_PV/default_fs_subPath/should_unmount_if_pod_is_force_deleted_while_kubelet_is_down_Disruptive_Slow_/csi-hostpath-attacher-0-csi-attacher.log
What happens when creating such logs is that the UI displays just the top-level directories but not the files inside them.
The simplest solution would be to keep the current grouping in the UI (directory name in bold to group files, underneath each file in that directory with a checkmark) but search more thoroughly for log files and allow nested directories. Then at least looking at the "artifects" directory would become easier.
But users of the log viewer would still see quite a few files they have no interest in. So some UI redesign with nested grouping and deeper groups folded away by default would be needed to address that.
Why is this needed:
These logs for storage tests have proven to be very useful for analysing errors involving the various CSI sidecar containers, see for example kubernetes-csi/external-attacher#102. But other groups now have to skip over a lot of files they have no interest, so moving them to sub-directories and UI enhancements to hide them by default would be useful.
/kind feature
/cc @msau42
The text was updated successfully, but these errors were encountered: