Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate merge-blocking jobs to dedicated cluster: pull-kubernetes-e2e-gce-network-proxy-http-connect #18854

Closed
spiffxp opened this issue Aug 14, 2020 · 3 comments · Fixed by #19153
Assignees
Labels
area/jobs kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. sig/testing Categorizes an issue or PR as relevant to SIG Testing.

Comments

@spiffxp
Copy link
Member

spiffxp commented Aug 14, 2020

What should be cleaned up or changed:

This is part of #18550

To properly monitor the outcome of this, you should be a member of k8s-infra-prow-viewers@kubernetes.io. PR yourself into https://github.com/kubernetes/k8s.io/blob/master/groups/groups.yaml#L603-L628 if you're not a member.

Migrate pull-kubernetes-e2e-gce-network-proxy-http-connect to k8s-infra-prow-build by adding a cluster: k8s-infra-prow-build field to the job:

NOTE: migrating this job is not as straightforward as some of the other #18550 issues, because:

  • it doesn't run for every single PR
  • so in terms of appropriate amount of PR traffic, either manually trigger this job, or look for open PRs that have triggered this job (e.g. using the job-history link below), and explicitly /test <this-job-name> on them

Once the PR has merged, note the date/time it merged. This will allow you to compare before/after behavior.

Things to watch for the job

Things to watch for the build cluster

Keep this open for at least 24h of weekday PR traffic. If everything continues to look good, then this can be closed.

/wg k8s-infra
/sig testing
/area jobs
/help

@spiffxp spiffxp added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Aug 14, 2020
@k8s-ci-robot k8s-ci-robot added wg/k8s-infra sig/testing Categorizes an issue or PR as relevant to SIG Testing. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. area/jobs labels Aug 14, 2020
@spiffxp spiffxp added this to Backlog in CI Policy Improvements via automation Aug 14, 2020
@spiffxp spiffxp moved this from Backlog to Next Priority in CI Policy Improvements Aug 14, 2020
@RobertKielty
Copy link
Member

/assign
/remove-help

@k8s-ci-robot k8s-ci-robot removed the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Aug 15, 2020
@RobertKielty RobertKielty moved this from Next Priority to In Progress in CI Policy Improvements Aug 15, 2020
@RobertKielty RobertKielty moved this from In Progress to Next Priority in CI Policy Improvements Aug 15, 2020
@RobertKielty RobertKielty moved this from Next Priority to In Progress in CI Policy Improvements Aug 15, 2020
@RobertKielty
Copy link
Member

@spiffxp I submitted a PR for this a few days ago but failed to add "fixes" in order to link it back to this issue.

When you get a chance can you take a look and approve the change? Many thanks.

@spiffxp
Copy link
Member Author

spiffxp commented Sep 10, 2020

#19153 has a merge conflict

I'll trigger a few more runs and keep an eye on https://prow.k8s.io/pr-history/?org=kubernetes&repo=kubernetes&pr=94127

This job runs so infrequently that as long as its behavior looks close to the gce or ubuntu e2e jobs I'll be happy with it once the real job is replaced with the changes in the canary (minus the testgrid dashboard change)

CI Policy Improvements automation moved this from In Progress to Closed Sep 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/jobs kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. sig/testing Categorizes an issue or PR as relevant to SIG Testing.
Projects
Development

Successfully merging a pull request may close this issue.

3 participants