Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removes canary job that tested migration changes #19153

Merged
merged 1 commit into from
Sep 11, 2020
Merged

removes canary job that tested migration changes #19153

merged 1 commit into from
Sep 11, 2020

Conversation

RobertKielty
Copy link
Member

fixes #18854

The configuration changes were ...

migrating pull-kubernetes-e2e-gce-network-proxy-http-connect
onto the k8s-infra-prow-build cluster

removing container startup flag --gcp-project=k8s-network-proxy-e2e

@spiffxp
This is a second PR to implement this change I closed the previous one.

The presentation of the diff here by git is awkward owing to the duplication of the job to canary test the changes.

  The configuration changes were ...
  migrating pull-kubernetes-e2e-gce-network-proxy-http-connect
  onto the k8s-infra-prow-build cluster

  removing container startup flag --gcp-project=k8s-network-proxy-e2e
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/jobs sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Sep 9, 2020
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 9, 2020
@spiffxp
Copy link
Member

spiffxp commented Sep 9, 2020

needs rebase, I will check on in this tomorrow AM PT

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 10, 2020
Copy link
Member

@spiffxp spiffxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RobertKielty, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 11, 2020
@k8s-ci-robot k8s-ci-robot merged commit a47ed95 into kubernetes:master Sep 11, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Sep 11, 2020
@k8s-ci-robot
Copy link
Contributor

@RobertKielty: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key sig-api-machinery-config.yaml using file config/jobs/kubernetes/sig-api-machinery/sig-api-machinery-config.yaml

In response to this:

fixes #18854

The configuration changes were ...

migrating pull-kubernetes-e2e-gce-network-proxy-http-connect
onto the k8s-infra-prow-build cluster

removing container startup flag --gcp-project=k8s-network-proxy-e2e

@spiffxp
This is a second PR to implement this change I closed the previous one.

The presentation of the diff here by git is awkward owing to the duplication of the job to canary test the changes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate merge-blocking jobs to dedicated cluster: pull-kubernetes-e2e-gce-network-proxy-http-connect
3 participants