Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flooding warnings in tide: BranchProtectionWarnings #21983

Closed
chaodaiG opened this issue Apr 27, 2021 · 3 comments · Fixed by #21984
Closed

Flooding warnings in tide: BranchProtectionWarnings #21983

chaodaiG opened this issue Apr 27, 2021 · 3 comments · Fixed by #21984
Labels
area/prow Issues or PRs related to prow kind/bug Categorizes issue or PR as related to a bug. sig/testing Categorizes an issue or PR as relevant to SIG Testing.
Milestone

Comments

@chaodaiG
Copy link
Contributor

What happened:

Tide runs every minute, it emits the same warning every time it runs:

jsonPayload: {
func: "k8s.io/test-infra/prow/config.(*Config).BranchProtectionWarnings"
file: "prow/config/branch_protection.go:451"
component: "tide"
msg: "The following repos define a policy or require context(s), but have one or more branches with protect: false"
controller: "sync"
level: "warning"
repos: "kubernetes-sigs/aws-ebs-csi-driver=gh-pages,kubernetes-sigs/aws-efs-csi-driver=gh-pages,kubernetes-sigs/aws-fsx-csi-driver=gh-pages,kubernetes-sigs/nfs-subdir-external-provisioner=gh-pages,kubernetes-sigs/node-feature-discovery-operator=gh-pages,kubernetes-sigs/node-feature-discovery=gh-pages,kubernetes/cloud-provider-aws=gh-pages,kubernetes/cloud-provider-openstack=gh-pages,kubernetes/ingress-nginx=gh-pages,kubernetes/kube-state-metrics=gh-pages"
}

What you expected to happen:

This is not an actionable warning for prow operator, doesn't make much sense alert every minute.

@chaodaiG chaodaiG added the kind/bug Categorizes issue or PR as related to a bug. label Apr 27, 2021
@chaodaiG chaodaiG changed the title Flooding warnings in tide: Flooding warnings in tide: BranchProtectionWarnings Apr 27, 2021
@chaodaiG
Copy link
Contributor Author

/area prow

@k8s-ci-robot k8s-ci-robot added the area/prow Issues or PRs related to prow label Apr 27, 2021
@chaodaiG
Copy link
Contributor Author

For example in #20157, it's intended not to protect aws-ebs-csi-driver gh-pages branch

@spiffxp
Copy link
Member

spiffxp commented Aug 11, 2021

/sig testing
/milestone v1.22

@k8s-ci-robot k8s-ci-robot added the sig/testing Categorizes an issue or PR as relevant to SIG Testing. label Aug 11, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Aug 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/prow Issues or PRs related to prow kind/bug Categorizes issue or PR as related to a bug. sig/testing Categorizes an issue or PR as relevant to SIG Testing.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants