-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't protect aws-ebs-csi-driver gh-pages branch #20157
Conversation
/lgtm |
@ayberk: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Is this the best way to handle another automated process making changes to a repository? |
Is it not possible to grant the GH action permission to push to the branch and ignore requirements such as status contexts? This can be done for normal users by granting them admin access. It looks like branch protection has been disabled for another kubernetes-sigs repo (#19770), but I'd like to get Aaron's and/or Cristoph's approval since this would allow bypassing the |
This is fine for automation purposes. Thanks for checking, @cjwagner /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cblecker, wongma7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
@wongma7: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
We want this GitHub action https://github.com/kubernetes-sigs/aws-ebs-csi-driver/blob/master/.github/workflows/helm-chart-release.yaml (using https://github.com/helm/chart-releaser-action) to automatically update our index file https://github.com/kubernetes-sigs/aws-ebs-csi-driver/blob/gh-pages/index.yaml and create GitHub releases.
To allow the GitHub action to push to GitHub, the gh-pages branch can't be protected.
! [remote rejected] HEAD -> gh-pages (protected branch hook declined)
https://github.com/kubernetes-sigs/aws-ebs-csi-driver/runs/1513656332. So I am making the branch unprotected. We won't accept PRs to it, from now on only the GitHub action ought to write to it.@ayberk
Ref: kubernetes-sigs/aws-ebs-csi-driver#624 (comment)