Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't protect aws-ebs-csi-driver gh-pages branch #20157

Merged
merged 1 commit into from
Dec 8, 2020

Conversation

wongma7
Copy link
Contributor

@wongma7 wongma7 commented Dec 7, 2020

We want this GitHub action https://github.com/kubernetes-sigs/aws-ebs-csi-driver/blob/master/.github/workflows/helm-chart-release.yaml (using https://github.com/helm/chart-releaser-action) to automatically update our index file https://github.com/kubernetes-sigs/aws-ebs-csi-driver/blob/gh-pages/index.yaml and create GitHub releases.

To allow the GitHub action to push to GitHub, the gh-pages branch can't be protected. ! [remote rejected] HEAD -> gh-pages (protected branch hook declined) https://github.com/kubernetes-sigs/aws-ebs-csi-driver/runs/1513656332. So I am making the branch unprotected. We won't accept PRs to it, from now on only the GitHub action ought to write to it.

@ayberk

Ref: kubernetes-sigs/aws-ebs-csi-driver#624 (comment)

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 7, 2020
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/config Issues or PRs related to code in /config sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Dec 7, 2020
@ayberk
Copy link
Contributor

ayberk commented Dec 8, 2020

/lgtm

@k8s-ci-robot
Copy link
Contributor

@ayberk: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@chases2
Copy link
Contributor

chases2 commented Dec 8, 2020

Is this the best way to handle another automated process making changes to a repository?
/assign @cjwagner

@cjwagner
Copy link
Member

cjwagner commented Dec 8, 2020

Is it not possible to grant the GH action permission to push to the branch and ignore requirements such as status contexts? This can be done for normal users by granting them admin access.

It looks like branch protection has been disabled for another kubernetes-sigs repo (#19770), but I'd like to get Aaron's and/or Cristoph's approval since this would allow bypassing the cla/linuxfoundation check and I'm not sure if that is allowed. Seems like it could be acceptable though if Tide is disabled and the set of users with write access is heavily restricted to ensure no PRs merge.

@cjwagner
Copy link
Member

cjwagner commented Dec 8, 2020

whoops
/assign @spiffxp @cblecker

@cblecker
Copy link
Member

cblecker commented Dec 8, 2020

This is fine for automation purposes. Thanks for checking, @cjwagner

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, wongma7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 8, 2020
@nckturner
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 8, 2020
@k8s-ci-robot k8s-ci-robot merged commit b828078 into kubernetes:master Dec 8, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Dec 8, 2020
@k8s-ci-robot
Copy link
Contributor

@wongma7: Updated the config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key config.yaml using file config/prow/config.yaml

In response to this:

We want this GitHub action https://github.com/kubernetes-sigs/aws-ebs-csi-driver/blob/master/.github/workflows/helm-chart-release.yaml (using https://github.com/helm/chart-releaser-action) to automatically update our index file https://github.com/kubernetes-sigs/aws-ebs-csi-driver/blob/gh-pages/index.yaml and create GitHub releases.

To allow the GitHub action to push to GitHub, the gh-pages branch can't be protected. ! [remote rejected] HEAD -> gh-pages (protected branch hook declined) https://github.com/kubernetes-sigs/aws-ebs-csi-driver/runs/1513656332. So I am making the branch unprotected. We won't accept PRs to it, from now on only the GitHub action ought to write to it.

@ayberk

Ref: kubernetes-sigs/aws-ebs-csi-driver#624 (comment)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants