Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post http://cherrypicker "connection refused" #23527

Closed
chaodaiG opened this issue Sep 9, 2021 · 12 comments
Closed

Post http://cherrypicker "connection refused" #23527

chaodaiG opened this issue Sep 9, 2021 · 12 comments
Labels
area/prow Issues or PRs related to prow kind/bug Categorizes issue or PR as related to a bug. sig/testing Categorizes an issue or PR as relevant to SIG Testing.

Comments

@chaodaiG
Copy link
Contributor

chaodaiG commented Sep 9, 2021

Seeing repeating errors in prow log:

component: "hook"
error: "Post "http://cherrypicker": dial tcp 10.111.255.241:80: connect: connection refused"
event-GUID: "bc8c7ab0-117d-11ec-96b5-a44cde3aa62f"
event-type: "pull_request"
external-plugin: "cherrypicker"
file: "prow/hook/server.go:225"
func: "k8s.io/test-infra/prow/hook.(*Server).demuxExternal.func1"
level: "error"
msg: "Error dispatching event to external plugin."
@chaodaiG chaodaiG added the kind/bug Categorizes issue or PR as related to a bug. label Sep 9, 2021
@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Sep 9, 2021
@chaodaiG
Copy link
Contributor Author

chaodaiG commented Sep 9, 2021

/area prow
/cc @alvaroaleman

@k8s-ci-robot k8s-ci-robot added the area/prow Issues or PRs related to prow label Sep 9, 2021
@chaodaiG
Copy link
Contributor Author

chaodaiG commented Sep 9, 2021

/sig testing

@k8s-ci-robot k8s-ci-robot added sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 9, 2021
@alvaroaleman
Copy link
Member

What does the cherrypicker log say? I tried to find them in the cloud console with jsonPayload.component: cherrypicker but that didn't yield anything :(

@chaodaiG
Copy link
Contributor Author

chaodaiG commented Sep 9, 2021

kubectl get pods returns no cherrypick pods, let me see what's going on

@chaodaiG
Copy link
Contributor Author

chaodaiG commented Sep 9, 2021

ah

$ kubectl get deployment cherrypicker -oyaml
account default/cherrypicker: serviceaccount "cherrypicker" not found'

@alvaroaleman
Copy link
Member

That is weird, supposively cole fixed that with #23517

@chaodaiG
Copy link
Contributor Author

chaodaiG commented Sep 9, 2021

yeah, this is weird, the change from the fix was clearly applied by https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/post-test-infra-deploy-prow/1435773000631717888, not sure why it's still on old config

@chaodaiG
Copy link
Contributor Author

chaodaiG commented Sep 9, 2021

kubernetes/kubernetes#76367 (comment)

This is unfortunate, but both fields are honored because of a name change around the 1.0 timeframe. the deprecated serviceAccount field can be removed if a new apiVersion of pods is introduced, but until then, clearing a service account on an existing object requires explicitly setting both serviceAccount: "" and serviceAccountName: ""

@chaodaiG
Copy link
Contributor Author

chaodaiG commented Sep 9, 2021

seems easy enough, I'll create a PR :)

@chaodaiG
Copy link
Contributor Author

chaodaiG commented Sep 9, 2021

The deployment was fixed, and cherrypicker still crashlooping:

{"component":"cherrypicker","error":"failed to get git authentication: error getting bot name: fetching bot name from GitHub: status code 401 not one of [200], body: {\"message\":\"Requires authentication\",\"documentation_url\":\"https://docs.github.com/rest/reference/users#get-the-authenticated-user\"}","file":"prow/external-plugins/cherrypicker/main.go:108","func":"main.main","level":"fatal","msg":"Error getting Git client.","severity":"fatal","time":"2021-09-09T17:34:30Z"}

@alvaroaleman
Copy link
Member

It works: kubernetes-sigs/controller-runtime#1640 (comment)
/close

@k8s-ci-robot
Copy link
Contributor

@alvaroaleman: Closing this issue.

In response to this:

It works: kubernetes-sigs/controller-runtime#1640 (comment)
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/prow Issues or PRs related to prow kind/bug Categorizes issue or PR as related to a bug. sig/testing Categorizes an issue or PR as relevant to SIG Testing.
Projects
None yet
Development

No branches or pull requests

3 participants