Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vendor tests are running in test-infra (?) #5304

Closed
krzyzacy opened this issue Nov 1, 2017 · 7 comments
Closed

vendor tests are running in test-infra (?) #5304

krzyzacy opened this issue Nov 1, 2017 · 7 comments
Assignees
@BenTheElder
Labels
area/bazel kind/bug Categorizes issue or PR as related to a bug.

Comments

@krzyzacy
Copy link
Member

krzyzacy commented Nov 1, 2017

https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/test-infra/5284/pull-test-infra-bazel/9538/
@BenTheElder
Copy link
Member

/area bazel
/kind bug
/assign

@k8s-ci-robot k8s-ci-robot added area/bazel kind/bug Categorizes issue or PR as related to a bug. labels Nov 1, 2017
@spxtr
Copy link
Contributor

spxtr commented Nov 1, 2017

Err, godep is supposed to drop all _test.go files.

@krzyzacy
Copy link
Member Author

krzyzacy commented Nov 1, 2017

ah - @spxtr I think you are right - since these days we are adding dependencies manually in test-infra

@dims
Copy link
Member

dims commented Nov 1, 2017

hehe, i thought it was by design i saw it a few days ago.

@BenTheElder
Copy link
Member

Err, godep is supposed to drop all _test.go files.

We shouldn't be running them anyhow. k/k explicitly excludes vendor in bazel test/build for this reason.

@spxtr
Copy link
Contributor

spxtr commented Nov 1, 2017

k/k excludes them because of the staging stuff I think. Could be wrong. We can exclude them as in this PR but we should also remove them at the same time.

@BenTheElder
Copy link
Member

fixed in #5308
we should still fix the vendor dir, see #5301

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BenTheElder BenTheElder

Labels
area/bazel kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@dims @BenTheElder @krzyzacy @spxtr @k8s-ci-robot