Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't build or test vendor in test-infra #5308

Merged
merged 1 commit into from
Nov 1, 2017

Conversation

BenTheElder
Copy link
Member

/area bazel
/area jobs

@k8s-ci-robot k8s-ci-robot added area/bazel area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 1, 2017
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 1, 2017
@BenTheElder
Copy link
Member Author

cc @ixdy

@spxtr
Copy link
Contributor

spxtr commented Nov 1, 2017

Instead, just delete all _test.go files under vendor.

@BenTheElder
Copy link
Member Author

@spxtr these are bazel tests so you'd have to fix up the BUILD files, I don't think there is any reason to run these. k/k already does this.

@spxtr
Copy link
Contributor

spxtr commented Nov 1, 2017

Right, delete the test files and then rerun gazelle. When we switch to go dep it will do that for us, fortunately. Now we're in an awkward place where we have Godeps/Godeps.json but we don't actually use it as a source of truth.

@BenTheElder
Copy link
Member Author

Right, delete the test files and then rerun gazelle. When we switch to go dep it will do that for us, fortunately. Now we're in an awkward place where we have Godeps/Godeps.json but we don't actually use it as a source of truth.

Sure we could (should?), but I don't see any reason to not also explicitly exclude them in the bazel jobs the same way that we do for k/k, which is somewhat orthogonal.

@krzyzacy
Copy link
Member

krzyzacy commented Nov 1, 2017

I think we can have both. We should not need to build vendor stuff though.
Maybe a separate PR to delete all the _test.go files in test-infra?
/lgtm
/hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Nov 1, 2017
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, krzyzacy

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@BenTheElder
Copy link
Member Author

/hold cancel
see: #5301 for migrating to dep

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 1, 2017
@k8s-ci-robot k8s-ci-robot merged commit 7dea542 into kubernetes:master Nov 1, 2017
@k8s-ci-robot
Copy link
Contributor

@BenTheElder: I updated Prow config for you!

In response to this:

/area bazel
/area jobs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@BenTheElder BenTheElder deleted the bazel-no-test-vendor branch November 1, 2017 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/bazel area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants