Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When dep supports excluding vendored tests, remove checking for them #5488

Closed
BenTheElder opened this issue Nov 14, 2017 · 2 comments · Fixed by #6443
Closed

When dep supports excluding vendored tests, remove checking for them #5488

BenTheElder opened this issue Nov 14, 2017 · 2 comments · Fixed by #6443
Assignees
@BenTheElder @ixdy
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. priority/backlog Higher priority than priority/awaiting-more-evidence.

Comments

@BenTheElder
Copy link
Member

IE revert #5411 once golang/dep#944 is closed.
/assign
@BenTheElder
Copy link
Member Author

This is getting closer to being something we can do, we should definitely do that when we can.

@BenTheElder BenTheElder added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. priority/backlog Higher priority than priority/awaiting-more-evidence. labels Dec 11, 2017
This was referenced Dec 27, 2017
Closed
Closed
@BenTheElder BenTheElder mentioned this issue Jan 9, 2018
Closed
@BenTheElder BenTheElder mentioned this issue Jan 26, 2018
Merged
@BenTheElder
Copy link
Member Author

/assign @ixdy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BenTheElder BenTheElder

@ixdy ixdy

Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use dep v0.4.1 in kubernetes/test-infra ixdy/kubernetes-test-infra
2 participants
@BenTheElder @ixdy