Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update readme to exclude vendor in bazel commands #6094

Closed
wants to merge 1 commit into from
Closed

update readme to exclude vendor in bazel commands #6094

wants to merge 1 commit into from

Conversation

BenTheElder
Copy link
Member

vendor/ periodically has problematic targets (mostly related to #5488)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 27, 2017
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 27, 2017
@BenTheElder BenTheElder added area/bazel and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 27, 2017
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 27, 2017
@BenTheElder BenTheElder added the kind/documentation Categorizes issue or PR as related to documentation. label Dec 27, 2017
@BenTheElder
Copy link
Member Author

this should also ~cover #6087 though we might want to add a pointer to planter 🤔

@chrislovecnm
Copy link
Contributor

Yes, we need a pointer to planter. It would be awesome that a new developer could read the document and build test infra on osx.

chrislovecnm
chrislovecnm reviewed Dec 30, 2017
View reviewed changes
Copy link
Contributor

@chrislovecnm chrislovecnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need more details. Planter, an example. Also I do not think the command works for me with planter.

@BenTheElder
Copy link
Member Author

/hold
probably taking a stab at this from the other direction (looking at what we can do about vendor/...) soon...

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 7, 2018
@BenTheElder BenTheElder closed this Jan 8, 2018
@BenTheElder BenTheElder deleted the vendor-is-fun branch January 8, 2018 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrislovecnm chrislovecnm chrislovecnm left review comments

@ixdy ixdy Awaiting requested review from ixdy

Assignees
No one assigned
Labels
area/bazel cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/documentation Categorizes issue or PR as related to documentation. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BenTheElder @k8s-ci-robot @chrislovecnm