-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merging master in feature branch fails because of CLA #8621
Comments
@fejta how did we fix this before with k8s-ci-robot and test-infra? k8s-merge-robot needs the same fix. |
/kind bug |
this was "handled" by having "feature branch managers" who just force push over the branch IIRC Lines 172 to 174 in 1f481a3
|
We have the similar problem in kubernetes-client/python repo. The release process in client-python requires merging master into release branch. The recently-enabled k8s-ci-bot in that repo blocks the release because it hasn't signed CLA: kubernetes-client/python#650 I suspect other kubernetes-client repos #9122 that have the bot enabled recently experience the similar issue. @BenTheElder @fejta Could you advise on how to proceed? :) |
Thanks for the reference @BenTheElder. I thought there were two bots ( I guess we have to force push like how the serverside-apply feature branch does until #8241 is rolled out. cc @yliaog |
I don't know what the correct answer for the k8s-ci-robot is there ... @spiffxp punting this up to steering :^) |
@BenTheElder - /me channeling Aaron - "as long as you come to steering with a yay or nay proposal" :) |
/milestone v1.13 |
@BenTheElder Is this still an issue? I feel like you mentioned one of the bot accounts was now mysteriously passing the CLA check, I can't remember if it was related to this |
/remove-milestone |
/milestone clear right, our syntax is inconsistent |
IIRC the bot now passes CLA, @fejta can confirm. |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
/close per last comment from @BenTheElder |
@dims: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/reopen The CLA bot no longer (or perhaps never) passes CLA check for PRs where it is the committer (e.g. kubernetes-client/java#3345) Is there a way to fix this globally with the EasyCLA infrastructure? |
@brendandburns: Reopened this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/sig testing I read the error message a little more, I think that the email address (k8s.ci.robot@gmail.com) needs to be added to the github user for the robot: https://github.com/k8s-ci-robot and then the EasyCLA check will pass (or at least get past the current error) |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues. This bot triages un-triaged issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
Because the bot hasn't signed the CLA, it's not currently possible to merge master back into the feature branch.
The text was updated successfully, but these errors were encountered: