Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merging master in feature branch fails because of CLA #8621

Open
apelisse opened this issue Jul 9, 2018 · 22 comments
Open

Merging master in feature branch fails because of CLA #8621

apelisse opened this issue Jul 9, 2018 · 22 comments
Assignees
@fejta
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. sig/testing Categorizes an issue or PR as relevant to SIG Testing.

Comments

@apelisse
Copy link
Member

apelisse commented Jul 9, 2018

Because the bot hasn't signed the CLA, it's not currently possible to merge master back into the feature branch.
@apelisse
Copy link
Member Author

apelisse commented Jul 9, 2018

@BenTheElder

@BenTheElder
Copy link
Member

@fejta how did we fix this before with k8s-ci-robot and test-infra? k8s-merge-robot needs the same fix.

@stevekuznetsov
Copy link
Contributor

/kind bug
/priority critical-urgent
@fejta @BenTheElder was this handled?

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. labels Aug 31, 2018
@BenTheElder
Copy link
Member

BenTheElder commented Aug 31, 2018 •
edited

this was "handled" by having "feature branch managers" who just force push over the branch IIRC

test-infra/prow/plugins.yaml

Lines 172 to 174 in 1f481a3

feature-serverside-apply:
- lavalamp # feature-serverside-apply "branch manager"
- apelisse # feature-serverside-apply "branch manager"

@roycaihw
Copy link
Member

We have the similar problem in kubernetes-client/python repo. The release process in client-python requires merging master into release branch. The recently-enabled k8s-ci-bot in that repo blocks the release because it hasn't signed CLA: kubernetes-client/python#650

I suspect other kubernetes-client repos #9122 that have the bot enabled recently experience the similar issue.

@BenTheElder @fejta Could you advise on how to proceed? :)

@roycaihw roycaihw mentioned this issue Oct 15, 2018
Merged
@BenTheElder
Copy link
Member

#8241

@roycaihw
Copy link
Member

Thanks for the reference @BenTheElder. I thought there were two bots (k8s-ci-robot that does auto-merging and CLAbot that checks CLA) and I was hoping our problem could be solved if the k8s-ci-robot can sign the CLA itself like a general contributor somehow.

I guess we have to force push like how the serverside-apply feature branch does until #8241 is rolled out.

cc @yliaog

@BenTheElder
Copy link
Member

I don't know what the correct answer for the k8s-ci-robot is there ... @spiffxp punting this up to steering :^)

@dims
Copy link
Member

dims commented Oct 16, 2018

@BenTheElder - /me channeling Aaron - "as long as you come to steering with a yay or nay proposal" :)

@spiffxp
Copy link
Member

spiffxp commented Oct 19, 2018

/milestone v1.13

@k8s-ci-robot k8s-ci-robot added this to the v1.13 milestone Oct 19, 2018
@BenTheElder
Copy link
Member

cc @thockin at @spiffxp's suggestion ... should the merge robot have the CLA authorized on its account?

@spiffxp
Copy link
Member

spiffxp commented Jan 3, 2019

@BenTheElder Is this still an issue? I feel like you mentioned one of the bot accounts was now mysteriously passing the CLA check, I can't remember if it was related to this

@spiffxp
Copy link
Member

spiffxp commented Jan 3, 2019

/remove-milestone

@spiffxp
Copy link
Member

spiffxp commented Jan 3, 2019

/milestone clear

right, our syntax is inconsistent

@k8s-ci-robot k8s-ci-robot removed this from the v1.13 milestone Jan 3, 2019
@BenTheElder
Copy link
Member

IIRC the bot now passes CLA, @fejta can confirm.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 3, 2019
@dims
Copy link
Member

dims commented Apr 16, 2019

/close

per last comment from @BenTheElder

@k8s-ci-robot
Copy link
Contributor

@dims: Closing this issue.

In response to this:

/close

per last comment from @BenTheElder

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@brendandburns
Copy link
Contributor

/reopen

The CLA bot no longer (or perhaps never) passes CLA check for PRs where it is the committer (e.g. kubernetes-client/java#3345)

Is there a way to fix this globally with the EasyCLA infrastructure?

@k8s-ci-robot k8s-ci-robot reopened this Apr 24, 2024
@k8s-ci-robot
Copy link
Contributor

@brendandburns: Reopened this issue.

In response to this:

/reopen

The CLA bot no longer (or perhaps never) passes CLA check for PRs where it is the committer (e.g. kubernetes-client/java#3345)

Is there a way to fix this globally with the EasyCLA infrastructure?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Apr 24, 2024
@brendandburns
Copy link
Contributor

/sig testing

I read the error message a little more, I think that the email address (k8s.ci.robot@gmail.com) needs to be added to the github user for the robot: https://github.com/k8s-ci-robot and then the EasyCLA check will pass (or at least get past the current error)

@k8s-ci-robot k8s-ci-robot added sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 24, 2024
This was referenced Apr 24, 2024
Merged
Merged
@ityuhui ityuhui mentioned this issue May 21, 2024
Merged
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle rotten
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fejta fejta

Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. sig/testing Categorizes an issue or PR as relevant to SIG Testing.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests