Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename ic and pr go files #10078

Merged
merged 1 commit into from
Nov 8, 2018
Merged

Rename ic and pr go files #10078

merged 1 commit into from
Nov 8, 2018

Conversation

micw523
Copy link
Contributor

@micw523 micw523 commented Nov 8, 2018

Fixes #9776.
Renames the go files and modifies the bazel build file

@k8s-ci-robot
Copy link
Contributor

Welcome @micw523! It looks like this is your first PR to kubernetes/test-infra 🎉🎉

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 8, 2018
@k8s-ci-robot
Copy link
Contributor

Hi @micw523. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 8, 2018
@k8s-ci-robot k8s-ci-robot added the area/prow Issues or PRs related to prow label Nov 8, 2018
@fejta
Copy link
Contributor

fejta commented Nov 8, 2018

/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 8, 2018
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: f4e33310a60409dc11d672065198bc9a0d41ba18

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fejta, micw523

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 8, 2018
@k8s-ci-robot k8s-ci-robot merged commit 6387c58 into kubernetes:master Nov 8, 2018
@matthyx
Copy link
Contributor

matthyx commented Nov 9, 2018

I understand you are more a python developer, but next time please rename the *_test.go files as well...

@micw523
Copy link
Contributor Author

micw523 commented Nov 9, 2018

I’m sorry for that - I will clean this up.
However @matthyx, I thought you wanted to leave those as is based on the description of 9776...

@matthyx
Copy link
Contributor

matthyx commented Nov 9, 2018

Yeah, sorry for the confusing description...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/prow Issues or PRs related to prow cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants