Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show the running test-infra commit on the deck UI #10626

Merged
merged 1 commit into from
Jan 7, 2019
Merged

Show the running test-infra commit on the deck UI #10626

merged 1 commit into from
Jan 7, 2019

Conversation

Katharine
Copy link
Member

This is relatively frequently something I would like to know.

No idea if this is the right way to go about this sort of thing, but it appears to work. Appears at the bottom of the drawer like this:

image

/cc @ixdy @ibzib

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. area/prow Issues or PRs related to prow area/prow/deck Issues or PRs related to prow's deck component sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jan 5, 2019
cjwagner
cjwagner reviewed Jan 5, 2019
View reviewed changes
Copy link
Member

@cjwagner cjwagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

prow/cmd/deck/version/version.go Show resolved Hide resolved
@Katharine Katharine changed the title Show the current test-infra commit on the deck UI Show the running test-infra commit on the deck UI Jan 5, 2019
BenTheElder
BenTheElder approved these changes Jan 7, 2019
View reviewed changes
Copy link
Member

@BenTheElder BenTheElder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 7, 2019
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: fa549c0f049b7a1cac31538547c91ad3980b85fb

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, Katharine

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@BenTheElder
Copy link
Member

this is great, thanks!
/meow pony
/pony meow

@k8s-ci-robot
Copy link
Contributor

@BenTheElder: Bad category. Please see https://api.thecatapi.com/api/categories/list

In response to this:

this is great, thanks!
/meow pony
/pony meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

@BenTheElder: Couldn't find a pony matching that query.

In response to this:

this is great, thanks!
/meow pony
/pony meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ixdy
Copy link
Member

ixdy commented Jan 7, 2019

/meow meow
/pony pony

@k8s-ci-robot
Copy link
Contributor

@ixdy: Bad category. Please see https://api.thecatapi.com/api/categories/list

In response to this:

/meow meow
/pony pony

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

@ixdy: pony image

In response to this:

/meow meow
/pony pony

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Katharine
Copy link
Member Author

meow is now an alias for cat.

/pony meow

@k8s-ci-robot
Copy link
Contributor

@Katharine: pony image

In response to this:

meow is now an alias for cat.

/pony meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Katharine
Copy link
Member Author

This is both technically correct and also not at all what I was going for.

@k8s-ci-robot k8s-ci-robot merged commit 31e68b0 into kubernetes:master Jan 7, 2019
@xrstf xrstf mentioned this pull request Sep 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@idealhack idealhack idealhack left review comments

@cjwagner cjwagner cjwagner left review comments

@ixdy ixdy ixdy left review comments

@BenTheElder BenTheElder BenTheElder approved these changes

@ibzib ibzib Awaiting requested review from ibzib

Assignees

@BenTheElder BenTheElder

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/prow/deck Issues or PRs related to prow's deck component area/prow Issues or PRs related to prow cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@Katharine @k8s-ci-robot @BenTheElder @ixdy @idealhack @cjwagner @ibzib