Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bazel-build-test.yaml: use 'skeleton' for kubeadm jobs #10995

Merged
merged 1 commit into from
Jan 28, 2019
Merged

bazel-build-test.yaml: use 'skeleton' for kubeadm jobs #10995

merged 1 commit into from
Jan 28, 2019

Conversation

neolit123
Copy link
Member

recently did change these under kubernetes/sig-cluster-lifecycle but missed the pre-submits.

xref: kubernetes/kubernetes#73402

/assign @krzyzacy @BenTheElder
/priority important-soon
/kind cleanup
/area config

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. area/config Issues or PRs related to code in /config labels Jan 28, 2019
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 28, 2019
BenTheElder
BenTheElder approved these changes Jan 28, 2019
View reviewed changes
Copy link
Member

@BenTheElder BenTheElder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 28, 2019
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 29761bb6e73ec0ea30639d8e944f554cad46e27e

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, neolit123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 28, 2019
@k8s-ci-robot k8s-ci-robot merged commit cd84217 into kubernetes:master Jan 28, 2019
@k8s-ci-robot
Copy link
Contributor

@neolit123: Updated the job-config configmap using the following files:

  • key bazel-build-test.yaml using file config/jobs/kubernetes/sig-testing/bazel-build-test.yaml
  • key generated-security-jobs.yaml using file config/jobs/kubernetes-security/generated-security-jobs.yaml

In response to this:

recently did change these under kubernetes/sig-cluster-lifecycle but missed the pre-submits.

xref: kubernetes/kubernetes#73402

/assign @krzyzacy @BenTheElder
/priority important-soon
/kind cleanup
/area config

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenTheElder BenTheElder BenTheElder approved these changes

@krzyzacy krzyzacy Awaiting requested review from krzyzacy

Assignees

@BenTheElder BenTheElder

@krzyzacy krzyzacy

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@neolit123 @k8s-ci-robot @BenTheElder @krzyzacy