Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an e2e job for continuous Docker validation #113

Merged
merged 1 commit into from
Jun 20, 2016
Merged

Add an e2e job for continuous Docker validation #113

merged 1 commit into from
Jun 20, 2016

Conversation

wonderfly
Copy link
Contributor

@wonderfly wonderfly commented Jun 3, 2016 •
edited
Loading

It runs daily the default e2e tests on GCE, against k8s head, latest GCI build,
and latest Docker release.

Tested on my local Jenkins instance with kubernetes/kubernetes#26813

@dchen1107 @spxtr Can you review?

@wonderfly wonderfly changed the title Add a e2e job for continuous Docker validation Add an e2e job for continuous Docker validation Jun 3, 2016
spxtr
spxtr reviewed Jun 3, 2016
View reviewed changes
jenkins/job-configs/kubernetes-jenkins/kubernetes-e2e.yaml
# job does.
- job-template:
<<: *e2e_job_defaults
name: 'continuous-docker-validation{suffix}'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like this is a pretty nasty hack. Is there some way to make this just a regular Job?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I too didn't like this. Started with a single job then realized it wouldn't give me the variable expansions in e2e_job_defaults so came up with this way.

@spxtr
Copy link
Contributor

spxtr commented Jun 3, 2016

@fejta has been looking at cleaning up this file.

@spxtr
Copy link
Contributor

spxtr commented Jun 3, 2016

Something @fejta has been complaining about and is planning on fixing is the clutter in kubernetes-e2e.yaml. I think the plan is to move all the GCI jobs into their own file. There will be some duplication, but it should make it much easier to understand what's going on and hopefully negate the need for this sort of thing.

The general idea is to prefer duplication over confusion :)

@wonderfly
Copy link
Contributor Author

This sounds fair enough. I think we used to have them in a separate file.

@wonderfly
Copy link
Contributor Author

Do you have any suggestions for this particular PR?

@spxtr
Copy link
Contributor

spxtr commented Jun 3, 2016

Nope, I think this can go in as-is. Just wanted to let you know the plan.

@fejta
Copy link
Contributor

fejta commented Jun 6, 2016

LGTM, I can handle all the merge conflicts in my PR.

@spxtr
Copy link
Contributor

spxtr commented Jun 13, 2016

Whoops, sorry this didn't go in before the other stuff.

@wonderfly
Copy link
Contributor Author

No worries. I'll rebase.

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

@wonderfly
Add an e2e job for continuous Docker validation
e35cfc6 
It runs daily the default e2e tests on GCE, against k8s head, latest GCI build,
and latest Docker release.
@googlebot
Copy link

CLAs look good, thanks!

@wonderfly
Copy link
Contributor Author

Rebased. PTAL.

@spxtr
Copy link
Contributor

spxtr commented Jun 15, 2016

It's icky but I think it's fine to go in.

@spxtr spxtr added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 15, 2016
@wonderfly
Copy link
Contributor Author

The change that this PR depends on, kubernetes/kubernetes#26813, is in now. @spxtr Do you mind if I hand merge this?

@dchen1107
Copy link
Member

LGTM

@dchen1107
Copy link
Member

xref: kubernetes/kubernetes#25215

@fejta
Copy link
Contributor

fejta commented Jun 20, 2016

@wonderfly this repo doesn't have a mergebot: someone has to hand merge

@wonderfly
Copy link
Contributor Author

I can hand merge. Just wanted to give you guys a heads up.

@spxtr
Copy link
Contributor

spxtr commented Jun 20, 2016

Go for it.

@wonderfly wonderfly merged commit 8b91eec into kubernetes:master Jun 20, 2016
@wonderfly wonderfly deleted the docker_validation_test branch June 20, 2016 20:56
@aronchick aronchick mentioned this pull request Aug 25, 2016
Closed
16 tasks
simonswine pushed a commit to simonswine/test-infra that referenced this pull request Jan 16, 2018
@munnerz
Merge pull request kubernetes#113 from jetstack/munnerz-patch-5
c08f8b9 
Bump minikube prow jobs
mborsz pushed a commit to mborsz/test-infra that referenced this pull request Dec 14, 2018
@k8s-ci-robot
Merge pull request kubernetes#113 from krzysied/perfdash_image_repo
fcf9f47 
Correcting perfdash image repo name
MushuEE pushed a commit to MushuEE/test-infra that referenced this pull request Mar 17, 2022
@timburks
Merge pull request kubernetes#113 from bhenderson/fix-some-edge-cases
909070f 
Fix some edge cases
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@spxtr spxtr

@dchen1107 dchen1107

Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@wonderfly @spxtr @fejta @googlebot @dchen1107