-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add python tests as a new prow job. #1360
Conversation
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
|
||
VERSION = 0.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer we use the same version system as with kubekins-e2e
/lgtm |
- name: pull-test-infra-py-test | ||
always_run: true | ||
skip_report: true | ||
context: py test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we call this "prow py test"? or rename the other one from "prow go test" to just "go test?"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should rename the other to just "go test"
I think I'd prefer having fewer jobs to worry about. |
Also the levels of indirection are starting to hurt my brain:
I guess the first three steps can be generalized/parameterized, which would reduce some of the cognitive overhead. I can't imagine having to set up all of these steps every time we want to start a new job. |
Yeah, it does feel a bit complicated. We can cut that back by moving bootstrap functionality into prow itself, if that makes sense. |
Remove gce-scalability from blockers list
#1342. We have two options here. We can either
Both are pretty good. In this PR I add
pull-test-infra-py-test
, as a step down the second path. There is some duplication in/images/
, and I'd like to clean that up in a future PR if we go down this route. I'm partial to bazel, but that's a bit trickier.