-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AWS EFS CSI driver prow job #13618
Conversation
testgrid-tab-name: verify | ||
description: aws efs csi driver basic code verification | ||
testgrid-num-columns-recent: '30' | ||
- name: pull-aws-efs-csi-driver-unit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a sanity test target here as well since sanity test just got added recently
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
currently it will run under make test
. Do we want to make it a separate job?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, saw it. I'm good now
/lgtm |
LGTM label has been added. Git tree hash: b04cef40ea365df904c2c109dc06b014e94316aa
|
/approve |
/assign @krzyzacy please approve, TY |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: krzyzacy, leakingtapan, wongma7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@wongma7: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Based on #9872, however it seems files have moved around so I'm not sure if I'm missing anything.
fixes kubernetes-sigs/aws-efs-csi-driver#56
The e2e job won't do anything until kubernetes-sigs/aws-efs-csi-driver#55 merges.
/cc @leakingtapan