Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add AWS EFS CSI driver prow job #13618

Merged
merged 1 commit into from
Aug 6, 2019
Merged

Add AWS EFS CSI driver prow job #13618

merged 1 commit into from
Aug 6, 2019

Conversation

wongma7
Copy link
Contributor

@wongma7 wongma7 commented Jul 26, 2019

Based on #9872, however it seems files have moved around so I'm not sure if I'm missing anything.

fixes kubernetes-sigs/aws-efs-csi-driver#56

The e2e job won't do anything until kubernetes-sigs/aws-efs-csi-driver#55 merges.

/cc @leakingtapan

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/testgrid sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jul 26, 2019
leakingtapan
leakingtapan reviewed Jul 31, 2019
View reviewed changes
config/jobs/kubernetes-sigs/aws-efs-csi-driver/aws-efs-csi-driver-presubmits.yaml
testgrid-tab-name: verify
description: aws efs csi driver basic code verification
testgrid-num-columns-recent: '30'
- name: pull-aws-efs-csi-driver-unit
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a sanity test target here as well since sanity test just got added recently

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

currently it will run under make test. Do we want to make it a separate job?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, saw it. I'm good now

@leakingtapan leakingtapan mentioned this pull request Jul 31, 2019
Closed
@leakingtapan
Copy link

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 31, 2019
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: b04cef40ea365df904c2c109dc06b014e94316aa

@leakingtapan
Copy link

/approve

@wongma7
Copy link
Contributor Author

wongma7 commented Jul 31, 2019

/assign @krzyzacy

please approve, TY

@krzyzacy
Copy link
Member

krzyzacy commented Aug 6, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: krzyzacy, leakingtapan, wongma7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 6, 2019
@k8s-ci-robot k8s-ci-robot merged commit b3226a3 into kubernetes:master Aug 6, 2019
@k8s-ci-robot
Copy link
Contributor

@wongma7: Updated the job-config configmap in namespace default using the following files:

  • key aws-efs-csi-driver-presubmits.yaml using file config/jobs/kubernetes-sigs/aws-efs-csi-driver/aws-efs-csi-driver-presubmits.yaml

In response to this:

Based on #9872, however it seems files have moved around so I'm not sure if I'm missing anything.

fixes kubernetes-sigs/aws-efs-csi-driver#56

The e2e job won't do anything until kubernetes-sigs/aws-efs-csi-driver#55 merges.

/cc @leakingtapan

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Aug 6, 2019
@leakingtapan leakingtapan mentioned this pull request Sep 5, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leakingtapan leakingtapan leakingtapan left review comments

Assignees

@krzyzacy krzyzacy

@leakingtapan leakingtapan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/testgrid cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.16
Development

Successfully merging this pull request may close these issues.

Integrate e2e test with prow
4 participants
@wongma7 @leakingtapan @k8s-ci-robot @krzyzacy