Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass PULL_BASE_REF through to cluster-api builds. #14228

Merged

Conversation

Katharine
Copy link
Member

This will cause _PULL_BASE_REF to be available as a substitution to cluster-api's cloudbuild.yaml.

_PULL_BASE_REF will be the name of the ref that was pushed, e.g. master or release-0.2 or v0.2.

Due to GCB's strictness, merging this without updating that file to reference _PULL_BASE_REF in substitutions and $_PULL_BASE_REF in steps will cause it to fail to build. The strictness can (and probably should) be alleviated by adding this to the cloudbuild.yaml:

options:
  substitution_option: ALLOW_LOOSE

/cc @detiber @vincepri
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 6, 2019
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 6, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Katharine

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 6, 2019
@detiber
Copy link
Member

detiber commented Sep 9, 2019

I created kubernetes-sigs/cluster-api#1406 to unblock this PR.
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 9, 2019
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 66509562201042a30c759218b5bba1c6a03fa31e

@Katharine
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 9, 2019
@k8s-ci-robot k8s-ci-robot merged commit e5d3579 into kubernetes:master Sep 9, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Sep 9, 2019
@k8s-ci-robot
Copy link
Contributor

@Katharine: Updated the job-config configmap in namespace default using the following files:

  • key k8s-staging-cluster-api.yaml using file config/jobs/image-pushing/k8s-staging-cluster-api.yaml

In response to this:

This will cause _PULL_BASE_REF to be available as a substitution to cluster-api's cloudbuild.yaml.

_PULL_BASE_REF will be the name of the ref that was pushed, e.g. master or release-0.2 or v0.2.

Due to GCB's strictness, merging this without updating that file to reference _PULL_BASE_REF in substitutions and $_PULL_BASE_REF in steps will cause it to fail to build. The strictness can (and probably should) be alleviated by adding this to the cloudbuild.yaml:

options:
 substitution_option: ALLOW_LOOSE

/cc @detiber @vincepri
/hold

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants