-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass PULL_BASE_REF through to cluster-api builds. #14228
Pass PULL_BASE_REF through to cluster-api builds. #14228
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Katharine The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I created kubernetes-sigs/cluster-api#1406 to unblock this PR. |
LGTM label has been added. Git tree hash: 66509562201042a30c759218b5bba1c6a03fa31e
|
/hold cancel |
@Katharine: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This will cause
_PULL_BASE_REF
to be available as a substitution to cluster-api's cloudbuild.yaml._PULL_BASE_REF
will be the name of the ref that was pushed, e.g.master
orrelease-0.2
orv0.2
.Due to GCB's strictness, merging this without updating that file to reference
_PULL_BASE_REF
insubstitutions
and$_PULL_BASE_REF
insteps
will cause it to fail to build. The strictness can (and probably should) be alleviated by adding this to the cloudbuild.yaml:/cc @detiber @vincepri
/hold