Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pull-kubeadm-operator-verify presubmit job to k/kubeadm #14673

Merged

Conversation

fabriziopandini
Copy link
Member

As per kubernetes/enhancements#1239 enhancement, we are starting to prototype the kubeadm operator into k/kubeadm repository.

This PR adds the pull-kubeadm-operator-verify presubmit job so we can ensure a core set of checks is performed (spell check, go fmt, go vet, unit tests, etc.) before any changes merge.

/sig cluster-lifecycle
/area kubeadm

/assign @neolit123
/cc @ereslibre @yagonobre @yastij

/hold
until kubernetes/kubeadm#1824 is merged

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. labels Oct 9, 2019
@k8s-ci-robot
Copy link
Contributor

@fabriziopandini: The label(s) area/kubeadm cannot be applied. These labels are supported: api-review, community/discussion, community/maintenance, community/question, cuj/build-train-deploy, cuj/multi-user, platform/aws, platform/azure, platform/gcp, platform/minikube, platform/other

In response to this:

As per kubernetes/enhancements#1239 enhancement, we are starting to prototype the kubeadm operator into k/kubeadm repository.

This PR adds the pull-kubeadm-operator-verify presubmit job so we can ensure a core set of checks is performed (spell check, go fmt, go vet, unit tests, etc.) before any changes merge.

/sig cluster-lifecycle
/area kubeadm

/assign @neolit123
/cc @ereslibre @yagonobre @yastij

/hold
until kubernetes/kubeadm#1824 is merged

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/config Issues or PRs related to code in /config sig/testing Categorizes an issue or PR as relevant to SIG Testing. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 9, 2019
Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 9, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini, neolit123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Member

@yastij yastij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 9, 2019
@k8s-ci-robot k8s-ci-robot merged commit efb7475 into kubernetes:master Oct 9, 2019
@k8s-ci-robot
Copy link
Contributor

@fabriziopandini: Updated the job-config configmap in namespace default using the following files:

  • key kubeadm-presubmits.yaml using file config/jobs/kubernetes/kubeadm/kubeadm-presubmits.yaml

In response to this:

As per kubernetes/enhancements#1239 enhancement, we are starting to prototype the kubeadm operator into k/kubeadm repository.

This PR adds the pull-kubeadm-operator-verify presubmit job so we can ensure a core set of checks is performed (spell check, go fmt, go vet, unit tests, etc.) before any changes merge.

/sig cluster-lifecycle
/area kubeadm

/assign @neolit123
/cc @ereslibre @yagonobre @yastij

/hold
until kubernetes/kubeadm#1824 is merged

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Oct 9, 2019
Copy link
Member

@yagonobre yagonobre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fabriziopandini fabriziopandini deleted the pull-kubeadm-operator-verify branch October 10, 2019 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants