-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add pull-kubeadm-operator-verify presubmit job to k/kubeadm #14673
add pull-kubeadm-operator-verify presubmit job to k/kubeadm #14673
Conversation
@fabriziopandini: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini, neolit123 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/hold cancel
@fabriziopandini: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
As per kubernetes/enhancements#1239 enhancement, we are starting to prototype the kubeadm operator into k/kubeadm repository.
This PR adds the
pull-kubeadm-operator-verify
presubmit job so we can ensure a core set of checks is performed (spell check, go fmt, go vet, unit tests, etc.) before any changes merge./sig cluster-lifecycle
/area kubeadm
/assign @neolit123
/cc @ereslibre @yagonobre @yastij
/hold
until kubernetes/kubeadm#1824 is merged