Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: yamllint errors, typo in kubebuilder presubmit; dind docs #15291

Merged
merged 4 commits into from
Nov 17, 2019
Merged

fix: yamllint errors, typo in kubebuilder presubmit; dind docs #15291

merged 4 commits into from
Nov 17, 2019

Conversation

alexeldeib
Copy link
Member

@alexeldeib alexeldeib commented Nov 15, 2019 •
edited
Loading

Docker in docker requires that the jobs start up using the provided runner in /usr/local/bin/runner.sh. Update the doc comment to reflect the correct filepath, and update Kubebuilder to use the runner.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 15, 2019
@alexeldeib alexeldeib mentioned this pull request Nov 15, 2019
Merged
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/config Issues or PRs related to code in /config sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Nov 15, 2019
@alexeldeib
Copy link
Member Author

sorry to spam you guys

/assign @mengqiy @DirectXMan12

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/provider/aws Issues or PRs related to aws provider area/provider/azure Issues or PRs related to azure provider area/provider/gcp Issues or PRs related to gcp provider area/release-eng Issues or PRs related to the Release Engineering subproject sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/release Categorizes an issue or PR as relevant to SIG Release. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 15, 2019
@alexeldeib
Copy link
Member Author

buuuunch of yamllint errors in master which looked like a bad copy paste/automatic application of privileged security context where necessary + resource limits? Fixed 36 yamllint errors in unrelated code.

@alexeldeib
Copy link
Member Author

guess i'll follow the bot's directions now that it's not a one-liner

/assign @spiffxp

@alexeldeib alexeldeib changed the title fix: typo in kubebuilder presubmit; dind docs fix: yamllint errors, typo in kubebuilder presubmit; dind docs Nov 15, 2019
alexeldeib
alexeldeib commented Nov 15, 2019
View reviewed changes
config/prow/config.yaml
@@ -590,7 +590,7 @@ presets:
# docker-in-docker (with images/bootstrap) preset
# NOTE: using this also requires using that image,
# ensuring you run your test under either the ENTRYPOINT or:
# /usr/local/bin/runner my-test-command --foo --bar
# /usr/local/bin/runner.sh my-test-command --foo --bar
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

n.b.

@justaugustus
Copy link
Member

Thanks for the fixes, @alexeldeib!
/lgtm
/approve
/assign @cblecker @krzyzacy

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 16, 2019
@cblecker
Copy link
Member

/lgtm
/approve

Thanks for this! 🚀

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexeldeib, cblecker, justaugustus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 17, 2019
@k8s-ci-robot k8s-ci-robot merged commit 8ed0791 into kubernetes:master Nov 17, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Nov 17, 2019
@k8s-ci-robot
Copy link
Contributor

@alexeldeib: Updated the following 2 configmaps:

  • config configmap in namespace default at cluster default using the following files:
    • key config.yaml using file config/prow/config.yaml
  • job-config configmap in namespace default at cluster default using the following files:
    • key cloud-provider-azure-config.yaml using file config/jobs/kubernetes-sigs/cloud-provider-azure/cloud-provider-azure-config.yaml
    • key cluster-api-provider-aws-presubmits.yaml using file config/jobs/kubernetes-sigs/cluster-api-provider-aws/cluster-api-provider-aws-presubmits.yaml
    • key cluster-api-provider-gcp-presubmits.yaml using file config/jobs/kubernetes-sigs/cluster-api-provider-gcp/cluster-api-provider-gcp-presubmits.yaml
    • key cluster-api-provider-vsphere-ci.yaml using file config/jobs/kubernetes-sigs/cluster-api-provider-vsphere/cluster-api-provider-vsphere-ci.yaml
    • key gcp-compute-persistent-disk-csi-driver-postsubmits.yaml using file config/jobs/kubernetes-sigs/gcp-compute-persistent-disk-csi-driver/gcp-compute-persistent-disk-csi-driver-postsubmits.yaml
    • key kubebuilder-presubmits.yaml using file config/jobs/kubernetes-sigs/kubebuilder/kubebuilder-presubmits.yaml
    • key service-catalog-presubmits.yaml using file config/jobs/kubernetes-sigs/service-catalog/service-catalog-presubmits.yaml
    • key sig-storage-local-static-provisioner-trusted.yaml using file config/jobs/kubernetes-sigs/sig-storage-local-static-provisioner/sig-storage-local-static-provisioner-trusted.yaml
    • key cloud-provider-vsphere-config.yaml using file config/jobs/kubernetes/cloud-provider-vsphere/cloud-provider-vsphere-config.yaml
    • key sig-cli-config.yaml using file config/jobs/kubernetes/sig-cli/sig-cli-config.yaml
    • key eks-periodics.yaml using file config/jobs/kubernetes/sig-cloud-provider/aws/eks/eks-periodics.yaml
    • key upgrade-gke.yaml using file config/jobs/kubernetes/sig-cloud-provider/gcp/upgrade-gke.yaml
    • key kubernetes-builds.yaml using file config/jobs/kubernetes/sig-release/kubernetes-builds.yaml
    • key conformance-e2e.yaml using file config/jobs/kubernetes/sig-testing/conformance-e2e.yaml
    • key coverage.yaml using file config/jobs/kubernetes/sig-testing/coverage.yaml

In response to this:

Docker in docker requires that the jobs start up using the provided runner in /usr/local/bin/runner.sh. Update the doc comment to reflect the correct filepath, and update Kubebuilder to use the runner.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chases2 chases2 Awaiting requested review from chases2

@mengqiy mengqiy Awaiting requested review from mengqiy

Assignees

@spiffxp spiffxp

@DirectXMan12 DirectXMan12

@justaugustus justaugustus

@krzyzacy krzyzacy

@cblecker cblecker

@mengqiy mengqiy

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/provider/aws Issues or PRs related to aws provider area/provider/azure Issues or PRs related to azure provider area/provider/gcp Issues or PRs related to gcp provider area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.17
Development

Successfully merging this pull request may close these issues.
8 participants
@alexeldeib @justaugustus @cblecker @k8s-ci-robot @spiffxp @DirectXMan12 @krzyzacy @mengqiy