Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "stop skipping dynamic PV tests" #15829

Merged
merged 1 commit into from
Jan 9, 2020

Conversation

BenTheElder
Copy link
Member

This reverts commit b282c40. from #15826

You can see that kind started failing reliably, plagued by "exit 137" issues with kubectl exec (SIGKILL <> OOM?)

https://testgrid.k8s.io/presubmits-kubernetes-blocking#pull-kubernetes-e2e-kind&width=5&sort-by-flakiness=

I suspect the addition of the Dynamic PV tests must be causing this somehow (?)
If this doesn't clear things up I will also revert running the TCP CLOSE_WAIT test.

There were no changes to kind in this time period and nothing interesting in k/k.
You can however see when we started running these additional tests that we went solid red :/

/cc @spiffxp @aojea

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/config Issues or PRs related to code in /config sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jan 9, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 9, 2020
@BenTheElder
Copy link
Member Author

/priority critical-urgent

@k8s-ci-robot k8s-ci-robot added the priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. label Jan 9, 2020
@aojea
Copy link
Member

aojea commented Jan 9, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 9, 2020
@BenTheElder
Copy link
Member Author

https://prow.k8s.io/?job=pull-kubernetes-e2e-kind

Success rate over time: 3h: 32%, 12h: 64%, 48h: 73%

Screen Shot 2020-01-09 at 1 37 54 AM

Left side is now. the first red from the right in the grouping now is from Jan 08 23:19:34Jan 08 2020, 23:19:34 UTC-0800

We merged at ~ Jan 08 23:19:34Jan 08 2020, 23:10:00 UTC-800 #15826 (comment), after which we've only passed once.

@BenTheElder
Copy link
Member Author

Will try to root-cause more in the morning.

@k8s-ci-robot k8s-ci-robot merged commit ccefe7b into kubernetes:master Jan 9, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Jan 9, 2020
@k8s-ci-robot
Copy link
Contributor

@BenTheElder: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key kind-presubmits.yaml using file config/jobs/kubernetes-sigs/kind/kind-presubmits.yaml
  • key kubernetes-kind-presubmits.yaml using file config/jobs/kubernetes/sig-testing/kubernetes-kind-presubmits.yaml

In response to this:

This reverts commit b282c40. from #15826

You can see that kind started failing reliably, plagued by "exit 137" issues with kubectl exec (SIGKILL <> OOM?)

https://testgrid.k8s.io/presubmits-kubernetes-blocking#pull-kubernetes-e2e-kind&width=5&sort-by-flakiness=

I suspect the addition of the Dynamic PV tests must be causing this somehow (?)
If this doesn't clear things up I will also revert running the TCP CLOSE_WAIT test.

There were no changes to kind in this time period and nothing interesting in k/k.
You can however see when we started running these additional tests that we went solid red :/

/cc @spiffxp @aojea

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@BenTheElder
Copy link
Member Author

aside: due to conflicts this is not strictly a revert, but 🤷‍♂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants