-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "stop skipping dynamic PV tests" #15829
Conversation
This reverts commit b282c40.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BenTheElder The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/priority critical-urgent |
/lgtm |
https://prow.k8s.io/?job=pull-kubernetes-e2e-kind
Left side is now. the first red from the right in the grouping now is from We merged at ~ |
Will try to root-cause more in the morning. |
@BenTheElder: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
aside: due to conflicts this is not strictly a revert, but 🤷♂ |
This reverts commit b282c40. from #15826
You can see that kind started failing reliably, plagued by "exit 137" issues with kubectl exec (SIGKILL <> OOM?)
https://testgrid.k8s.io/presubmits-kubernetes-blocking#pull-kubernetes-e2e-kind&width=5&sort-by-flakiness=
I suspect the addition of the Dynamic PV tests must be causing this somehow (?)
If this doesn't clear things up I will also revert running the TCP CLOSE_WAIT test.
There were no changes to kind in this time period and nothing interesting in k/k.
You can however see when we started running these additional tests that we went solid red :/
/cc @spiffxp @aojea