Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve bazel rbe cache hit rate #16577

Merged
merged 1 commit into from
Mar 4, 2020
Merged

Improve bazel rbe cache hit rate #16577

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .bazelrc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,9 @@ build:remote --define=EXECUTOR=remote
build:remote --remote_executor=grpcs://remotebuildexecution.googleapis.com
build:remote --remote_timeout=3600

# Improve cache hit rate
build:remote --incompatible_strict_action_env=true

# Minimize what is downloaded
build:inmemory --experimental_inmemory_jdeps_files
build:inmemory --experimental_inmemory_dotd_files
Expand Down
1 change: 1 addition & 0 deletions prow/interrupts/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,4 +26,5 @@ go_test(
name = "go_default_test",
srcs = ["interrupts_test.go"],
embed = [":go_default_library"],
tags = ["local"], # TODO(fejta): non-hermetic tests fails on RBE
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there an issue for this?

)
1 change: 1 addition & 0 deletions prow/metrics/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ go_test(
"metrics_test.go",
],
embed = [":go_default_library"],
tags = ["local"], # TODO(fejta): non-hermetic tests fails on RBE
deps = [
"//prow/config:go_default_library",
"@io_k8s_utils//diff:go_default_library",
Expand Down
2 changes: 1 addition & 1 deletion prow/metrics/metrics_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ func TestExposeMetrics(t *testing.T) {
ExposeMetrics("my-component", config.PushGateway{})
resp, err := http.Get("http://127.0.0.1:9090/metrics")
if err != nil {
t.Errorf("failed getting metrics: %v", err)
t.Fatalf("failed getting metrics: %v", err)
}
if resp.StatusCode != http.StatusOK {
t.Errorf("resonse status was not 200 but %d", resp.StatusCode)
Expand Down