Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update prow to v20200305-062b3366c, and other images as necessary. #16639

Merged
merged 1 commit into from
Mar 6, 2020
Merged

Update prow to v20200305-062b3366c, and other images as necessary. #16639

merged 1 commit into from
Mar 6, 2020

Conversation

k8s-ci-robot
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot commented Mar 5, 2020 •
edited
Loading

Multiple distinct Prow changes:

Commits Dates Images
cff045c...062b336 2020‑03‑04 → 2020‑03‑05 boskos/aws-janitor, boskos/aws-janitor-boskos, boskos/boskos, boskos/cleaner, boskos/janitor, boskos/reaper
e8ef975...9e853ce 2020‑03‑05 → 2020‑03‑05 branchprotector, checkconfig, clonerefs, commenter, crier, deck, entrypoint, ghproxy, grandmatriarch, hook, horologium, initupload, label_sync, needs-rebase, pipeline, plank, sidecar, sinker, status-reconciler, tide, tot

Multiple distinct test-image changes:

Commits Dates Images
28c7418...3e08456 2020‑03‑03 → 2020‑03‑06 kubekins-e2e-master
26ebc13...3e08456 2020‑03‑05 → 2020‑03‑06 kubekins-e2e-1.15, kubekins-e2e-1.16, kubekins-e2e-1.17, kubekins-e2e-1.18, kubekins-e2e-experimental, kubekins-e2e-master

/cc @BenTheElder

@k8s-ci-robot k8s-ci-robot requested a review from BenTheElder March 5, 2020 22:10
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. area/boskos Issues or PRs related to code in /boskos area/config Issues or PRs related to code in /config area/label_sync Issues or PRs related to code in /label_sync area/provider/aws Issues or PRs related to aws provider area/provider/azure Issues or PRs related to azure provider area/provider/gcp Issues or PRs related to gcp provider area/prow Issues or PRs related to prow area/prow/branchprotector Issues or PRs related to prow's branchprotector component area/prow/bump Updates to the k8s prow cluster area/release-eng Issues or PRs related to the Release Engineering subproject sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. sig/windows Categorizes an issue or PR as relevant to SIG Windows. labels Mar 5, 2020
@k8s-ci-robot k8s-ci-robot changed the title Update prow to v20200305-062b3366c, and other images as necessary. Update prow to v20200305-9e853ce03, and other images as necessary. Mar 5, 2020
@k8s-ci-robot k8s-ci-robot force-pushed the autobump branch 5 times, most recently from 124ec5a to 5bbef4d Compare March 6, 2020 18:10
@BenTheElder
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 6, 2020
@k8s-ci-robot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, k8s-ci-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 6, 2020
@k8s-ci-robot k8s-ci-robot changed the title Update prow to v20200305-9e853ce03, and other images as necessary. Update prow to v20200305-062b3366c, and other images as necessary. Mar 6, 2020
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 6, 2020
@BenTheElder
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 6, 2020
@k8s-ci-robot k8s-ci-robot merged commit a7ca868 into kubernetes:master Mar 6, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Mar 6, 2020
@mborsz
Copy link
Member

mborsz commented Mar 11, 2020

This image bump released a #16452 which fails kubemark in 1.15 branch.

See kubernetes/kubernetes#88962 (comment) for details.

What is a right action here?
Can we rollback this image bump to unblock all PRs in 1.15?

/cc @wojtek-t

@k8s-ci-robot k8s-ci-robot requested a review from wojtek-t March 11, 2020 10:43
@wojtek-t
Copy link
Member

@BenTheElder - I think we should revert it.

@BenTheElder
Copy link
Member

Hi, it looks like the kubetest changes were rolled back, we should probably roll forward the images now to pick this up, I'll do that now.

For quicker contact @test-infra-oncall in #testing-ops will send a realtime ping, at least for me github notifications have a much more variable delay.

@BenTheElder BenTheElder mentioned this pull request Mar 11, 2020
Merged
@BenTheElder
Copy link
Member

#16661 roll forward here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenTheElder BenTheElder Awaiting requested review from BenTheElder

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

Assignees

@BenTheElder BenTheElder

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/boskos Issues or PRs related to code in /boskos area/config Issues or PRs related to code in /config area/label_sync Issues or PRs related to code in /label_sync area/provider/aws Issues or PRs related to aws provider area/provider/azure Issues or PRs related to azure provider area/provider/gcp Issues or PRs related to gcp provider area/prow/branchprotector Issues or PRs related to prow's branchprotector component area/prow/bump Updates to the k8s prow cluster area/prow Issues or PRs related to prow area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.
4 participants
@k8s-ci-robot @BenTheElder @mborsz @wojtek-t