Set a ceiling on the number of extra files to attach. #16653
Merged
+293
−104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
approved
fejta
requested review from
michelle192837 and
chases2
and removed request for
cjwagner and
stevekuznetsov
| for _, a := range artifacts { // add started.json, etc to the invocation artifact list. | ||
| if total >= maxFiles { | ||
| continue |
There was a problem hiding this comment.
Should we log somewhere when we hit this case?
experiment/resultstore/main.go
Outdated
| if err := path.Set(p); err != nil { | ||
| return nil, fmt.Errorf("bad bucket: %w", err) | ||
| valid := func(path gcs.Path) bool { | ||
| buck := path.Bucket() |
There was a problem hiding this comment.
nit: 'b' or 'bucket'? 'buck' reads weird
k8s-ci-robot
added
do-not-merge/hold
Otherwise the server will reject invocations describing large jobs (which have tens of thousands of files).
k8s-ci-robot
removed
the
lgtm
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
michelle192837
approved these changes
Mar 6, 2020
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fejta, michelle192837 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise the server will reject invocations describing large jobs (which have tens of thousands of files).
Also:
ref #14009