gcsupload: limit maximum upload concurrency #16658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
stevekuznetsov
commented
Mar 6, 2020
| for dest, upload := range uploadTargets { | ||
| log := logrus.WithField("dest", dest) | ||
| if err := sem.Acquire(context.Background(), 1); err != nil { |
There was a problem hiding this comment.
Note: it's actually the dtw(dest) call we make in creating the closure that allocates, so we need to guard that
k8s-ci-robot
added
area/prow
fejta
reviewed
Mar 6, 2020
stevekuznetsov
force-pushed
the
skuznets/limit-gcsupload-paralellism
branch
from
ddaa716 to
114bda2
Compare
fejta
approved these changes
Mar 6, 2020
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fejta, stevekuznetsov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
needs-rebase
stevekuznetsov
force-pushed
the
skuznets/limit-gcsupload-paralellism
branch
from
114bda2 to
3a27750
Compare
k8s-ci-robot
removed
the
lgtm
stevekuznetsov
force-pushed
the
skuznets/limit-gcsupload-paralellism
branch
from
3a27750 to
6a7a272
Compare
k8s-ci-robot
removed
the
needs-rebase
Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
stevekuznetsov
force-pushed
the
skuznets/limit-gcsupload-paralellism
branch
from
6a7a272 to
6b72630
Compare
cjwagner
approved these changes
Mar 6, 2020
| @@ -38,11 +39,11 @@ type destToWriter func(dest string) dataWriter | |||
| // Upload uploads all of the data in the | |||
| // uploadTargets map to GCS in parallel. The map is | |||
| // keyed on GCS path under the bucket | |||
| func Upload(bucket *storage.BucketHandle, uploadTargets map[string]UploadFunc) error { | |||
| func Upload(bucket *storage.BucketHandle, uploadTargets map[string]UploadFunc, maxConcurrency int64) error { | |||
| dtw := func(dest string) dataWriter { | |||
| return gcsObjectWriter{bucket.Object(dest).NewWriter(context.Background())} | |||
There was a problem hiding this comment.
This is kind of orthogonal to this PR, but we should be using a context with a timeout here so that we don't try to upload a file forever, especially now that that could prevent other files from being uploaded as well.
k8s-ci-robot
added
the
lgtm
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Steve Kuznetsov skuznets@redhat.com
/cc @fejta @cjwagner @smarterclayton