Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sig-instrumentation failing tests and empty dashboards #17152

Merged
merged 1 commit into from
Apr 9, 2020

Conversation

serathius
Copy link
Contributor

@serathius serathius commented Apr 8, 2020

Removing:

  • Unsupported k8s versions (1.11, 1.12, 1.14)
  • Stackdriver tests that fail to start

Leaving:

/cc @brancz

@k8s-ci-robot k8s-ci-robot requested a review from brancz April 8, 2020 20:02
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/testgrid sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Apr 8, 2020
@serathius
Copy link
Contributor Author

/assign @brancz

@brancz
Copy link
Member

brancz commented Apr 9, 2020

Not sure I can actually approve any of this, but I’ll try.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 9, 2020
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 9, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brancz, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 9, 2020
Removing:
* Unsupported k8s versions (1.11, 1.12, 1.14)
* Stackdriver tests that fail to start

Leaving:
* Stackdriver tests as they have cases passing https://k8s-testgrid.appspot.com/sig-instrumentation-tests#gci-gce-sd-logging
* Elasticsearch tests to confirm with owner
* GKE dashboard as they require additional changes in parent directory
@brancz
Copy link
Member

brancz commented Apr 9, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 9, 2020
@k8s-ci-robot k8s-ci-robot merged commit 26b2d18 into kubernetes:master Apr 9, 2020
@k8s-ci-robot
Copy link
Contributor

@serathius: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key sig-instrumentation-config.yaml using file config/jobs/kubernetes/sig-instrumentation/sig-instrumentation-config.yaml

In response to this:

Removing:

  • Unsupported k8s versions (1.11, 1.12, 1.14)
  • Stackdriver tests that fail to start

Leaving:

/cc @brancz

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/testgrid cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants