Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

k8s-jkns-ci-node-e2e is busted switch to k8s-jkns-gke-gci-soak #17247

Merged
merged 1 commit into from
Apr 16, 2020
Merged

k8s-jkns-ci-node-e2e is busted switch to k8s-jkns-gke-gci-soak #17247

merged 1 commit into from
Apr 16, 2020

Conversation

dims
Copy link
Member

@dims dims commented Apr 16, 2020

different experiment compared to #17243

in 17243 we switched ci-kubernetes-node-kubelet to use the general boskos pool

in this, we are trying another empty project ci-kubernetes-node-kubelet-1-18

@dims
k8s-jkns-ci-node-e2e is busted switch to k8s-jkns-gke-gci-soak
131578a 
different experiment compared to kubernetes#17243

in 17243 we switched ci-kubernetes-node-kubelet to use the general boskos pool

in this, we are trying another empty project ci-kubernetes-node-kubelet-1-18
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Apr 16, 2020
@spiffxp
Copy link
Member

spiffxp commented Apr 16, 2020

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 16, 2020
hasheddan
hasheddan approved these changes Apr 16, 2020
View reviewed changes
Copy link
Contributor

@hasheddan hasheddan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

thanks @dims!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, hasheddan, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 8cb47b3 into kubernetes:master Apr 16, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Apr 16, 2020
@k8s-ci-robot
Copy link
Contributor

@dims: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key 1.18.yaml using file config/jobs/kubernetes/sig-release/release-branch-jobs/1.18.yaml

In response to this:

different experiment compared to #17243

in 17243 we switched ci-kubernetes-node-kubelet to use the general boskos pool

in this, we are trying another empty project ci-kubernetes-node-kubelet-1-18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spiffxp spiffxp mentioned this pull request Apr 17, 2020
Closed
@spiffxp
Copy link
Member

spiffxp commented Apr 17, 2020

ref: kubernetes/kubernetes#89892 (comment)

@spiffxp spiffxp mentioned this pull request Jun 17, 2021
Open
55 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hasheddan hasheddan hasheddan approved these changes

@feiskyer feiskyer Awaiting requested review from feiskyer

Assignees

@spiffxp spiffxp

@hasheddan hasheddan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dims @spiffxp @k8s-ci-robot @hasheddan