Add k8s-infra-prow-build's boskos to monitoring #17523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't have access to the prometheus instance for monitoring.prow.k8s.io so I'm not sure what the existing metrics look like. This should work well with the existing boskos resources dashboard. I'm not sure how well this will work with the boskos server dashboard. Do the scraped metrics automatically have a `host` or `target` tag included in them that could be added as a parameter?
k8s-ci-robot
added
cncf-cla: yes
spiffxp
commented
May 5, 2020
| @@ -39,7 +39,7 @@ dashboard.new( | |||
| {type: "gke-project", friendly: "GKE project"}, | |||
| {type: "gpu-project", friendly: "GPU project"}, | |||
| {type: "ingress-project", friendly: "Ingress project"}, | |||
| {type: "istio-project", friendly: "Istio project"}, | |||
There was a problem hiding this comment.
istio-project pool is unused at this point thanks to #17213
stevekuznetsov
approved these changes
May 5, 2020
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: spiffxp, stevekuznetsov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't have access to the prometheus instance for
monitoring.prow.k8s.io so I'm not sure what the existing metrics look
like. This should work well with the existing boskos resources
dashboard.
I'm not sure how well this will work with the boskos server
dashboard. Do the scraped metrics automatically have a
hostortargettag included in them that could be added as a parameter?
/cc @cjwagner @stevekuznetsov