Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop publishing latest-green.txt and migrate to k8s-infra-prow-build #17672

Merged
merged 1 commit into from
May 21, 2020

Conversation

spiffxp
Copy link
Member

@spiffxp spiffxp commented May 21, 2020

This migrates ci-kubernetes-e2e-gci-gce over to the k8s-infra owned
prow build cluster. The release branch variants of this job have
already been moved over. What was preventing this from moving over
was the --publish flag, implying that this job needed write access
to a bucket that won't allow non-google.com access.

I have looked using cs.k8s.io and can't find any code that actually
relies on the existence of latest-green.txt. I could have sworn that
it was at one time used by tooling in kubernetes/release (eg: as part
of find_green_build), but I haven't found it in history there either.

I've looked in this repo's history, and publishing to this path has
been present since inception, but I still can't find what might actually
be looking for this file.

It's referenced in docs in a few places, which I will PR to remove if
those are the only references.

/cc @fejta @ixdy
maybe you remember the history of this file?

This migrates ci-kubernetes-e2e-gci-gce over to the k8s-infra owned
prow build cluster. The release branch variants of this job have
already been moved over. What was preventing this from moving over
was the --publish flag, implying that this job needed write access
to a bucket that won't allow non-google.com access.

I have looked using cs.k8s.io and can't find any code that actually
relies on the existence of latest-green.txt. I could have sworn that
it was at one time used by tooling in kubernetes/release (eg: as part
of find_green_build), but I haven't found it in history there either.

I've looked in this repo's history, and publishing to this path has
been present since inception, but I still can't find what might actually
be looking for this file.

It's referenced in docs in a few places, which I will PR to remove if
those are the only references.
@k8s-ci-robot k8s-ci-robot requested review from fejta and ixdy May 21, 2020 04:27
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/jobs area/provider/gcp Issues or PRs related to gcp provider sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/testing Categorizes an issue or PR as relevant to SIG Testing. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 21, 2020
@spiffxp
Copy link
Member Author

spiffxp commented May 21, 2020

/hold
for comment
/cc @justaugustus
FYI

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 21, 2020
@spiffxp
Copy link
Member Author

spiffxp commented May 21, 2020

ref: kubernetes/k8s.io#841

@dims
Copy link
Member

dims commented May 21, 2020

/lgtm

Let's do this!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 21, 2020
@justaugustus
Copy link
Member

For releng, we rely on ci/latest.txt or ci/latest-x.y.txt:

https://github.com/kubernetes/release/blob/3544be5a6436265019b1e85606ba6b8e02d5ed48/pkg/release/version.go#L58-L60

which is produced from the ci-kubernetes-build jobs.

There are minimal references to latest-green, so I'm in favor of finally removing it.

/lgtm
/approve

Feel free to pull the hold at will.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justaugustus, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ixdy
Copy link
Member

ixdy commented May 21, 2020

Two places that come to mind where it may have been used at some point in the distant past:

  • anago (though you mention you haven't been able to find this anywhere)
  • kops e2e testing, when we wanted to test latest kops vs. a green kubernetes build (or vice-versa?)

@ixdy
Copy link
Member

ixdy commented May 21, 2020

The latest-green.txt file was added in 2015: kubernetes/kubernetes#10428

Amusingly, there was a recent comment about it: kubernetes/kubernetes#10410 (comment)

@ixdy
Copy link
Member

ixdy commented May 21, 2020

Also, I may have been thinking about kops' use of https://storage.googleapis.com/kops-ci/bin/latest-ci-updown-green.txt.

@spiffxp
Copy link
Member Author

spiffxp commented May 21, 2020

/hold cancel
Thanks for the additional history @ixdy. I feel reasonably confident we can drop this. Will open up PR's to address docs references to latest-green.txt

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 21, 2020
@k8s-ci-robot k8s-ci-robot merged commit f34d23c into kubernetes:master May 21, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone May 21, 2020
@k8s-ci-robot
Copy link
Contributor

@spiffxp: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key gcp-gce.yaml using file config/jobs/kubernetes/sig-cloud-provider/gcp/gcp-gce.yaml

In response to this:

This migrates ci-kubernetes-e2e-gci-gce over to the k8s-infra owned
prow build cluster. The release branch variants of this job have
already been moved over. What was preventing this from moving over
was the --publish flag, implying that this job needed write access
to a bucket that won't allow non-google.com access.

I have looked using cs.k8s.io and can't find any code that actually
relies on the existence of latest-green.txt. I could have sworn that
it was at one time used by tooling in kubernetes/release (eg: as part
of find_green_build), but I haven't found it in history there either.

I've looked in this repo's history, and publishing to this path has
been present since inception, but I still can't find what might actually
be looking for this file.

It's referenced in docs in a few places, which I will PR to remove if
those are the only references.

/cc @fejta @ixdy
maybe you remember the history of this file?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs area/provider/gcp Issues or PRs related to gcp provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants