remove ci-cri-containerd tests failing continually over past 400 days #18569
Conversation
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
area/config
k8s-ci-robot
added
the
needs-rebase
This set of containerd tests have been 100% failure runs for over 400 days. This means they have not ran successfully or had actionably constructive monitoring during the lifecycle of any Kubernetes release currently supported by the community, making their results irrelevant to the community today. Signed-off-by: Tim Pepper <tpepper@vmware.com>
tpepper
force-pushed
the
containerd_relevance
branch
from
cecd533
to
86b7160
Compare
k8s-ci-robot
removed
the
needs-rebase
|
Looks like @kubernetes/sig-node-pr-reviews don't consider an item until it has |
|
@tpepper: you cannot LGTM your own PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Checking on these jobs in https://storage.googleapis.com/k8s-gubernator/triage/index.html?date=2020-08-04&pr=1&job=ci-cri-containerd-e2e-gce-stackdriver
and for the most part these have been failing for years.
We should delete them.
/lgtm
k8s-ci-robot
added
the
lgtm
|
Would be nice to have a summary of what's deleted in the commit message. The only one I might be concerned about is Otherwise, if they've been failing for over a year, I think this is reasonable. We would have to reverse engineer each of them individually to find the original intent.\ |
|
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
|
I think it makes sense to go ahead and delete these failing jobs. I looked at the test results board, https://storage.googleapis.com/k8s-gubernator/triage/index.html?date=2020-08-04&pr=1&job=ci-cri-containerd-e2e-gce-stackdriver , which is new to me. I'm not quite sure how to see the history of this job beyond the default layout, which is about 19 days. Any pointers? This looks to be a good place/tool to get a broader view of how a test is performing (as well as testgrid). Given that there is also an open issue to come up with a test plan for containerd tests, I would expect to have these tests back online in a reasonable period of time. We just need to be sure to not let that issue linger too long, perhaps adjust the priority to high and add it the the project tracking dashboard. I will do that now. |
|
/lgtm |
|
/area test |
|
@vpickard: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/approve @vpickard please feel free to remove hold |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims, tpepper The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
|
@tpepper: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This set of containerd tests have been 100% failure runs for over 400
days. This means they have not ran successfully or had actionably
constructive monitoring during the lifecycle of any Kubernetes release
currently supported by the community, making their results irrelevant to
the community today.
Signed-off-by: Tim Pepper tpepper@vmware.com