Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop --gcp-project= flag from kubernetes network-proxy presubmits #19079

Merged
merged 2 commits into from
Sep 1, 2020
Merged

Drop --gcp-project= flag from kubernetes network-proxy presubmits #19079

merged 2 commits into from
Sep 1, 2020

Conversation

spiffxp
Copy link
Member

@spiffxp spiffxp commented Sep 1, 2020

Part of #18853
Followup to #18889

Let's find out if the gce-project pool in k8s-infra-prow-build meets the needs of these jobs.

Fixing grpc variant directly (ref: #18853 (comment)). If this works, we should revert #19033

Trying out http-connect variant via a canary (ref: #18904 (review))

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Sep 1, 2020
@spiffxp
Copy link
Member Author

spiffxp commented Sep 1, 2020

FYI @kubernetes/ci-signal

hasheddan
hasheddan approved these changes Sep 1, 2020
View reviewed changes
Copy link
Contributor

@hasheddan hasheddan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 1, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hasheddan, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spiffxp
Add pull-kubernetes-e2e-gce-network-proxy-http-connect-canary
c3a8268 
Drop the use of a specific project and migrate to k8s-infra, let's see
if the default gce-project pool over there can satisfy the needs of this
job

Also make the job optional
@spiffxp spiffxp force-pushed the drop-project-for-kubernetes-network-proxy-presubmits branch from 75c1c4e to c3a8268 Compare September 1, 2020 01:15
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 1, 2020
@spiffxp
Copy link
Member Author

spiffxp commented Sep 1, 2020

Made the canary job optional so tests don't yell at me to put it on kuberntes-presubmits-blocking testgrid

@hasheddan
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 1, 2020
@k8s-ci-robot k8s-ci-robot merged commit f50b922 into kubernetes:master Sep 1, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Sep 1, 2020
@k8s-ci-robot
Copy link
Contributor

@spiffxp: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key sig-api-machinery-config.yaml using file config/jobs/kubernetes/sig-api-machinery/sig-api-machinery-config.yaml

In response to this:

Part of #18853
Followup to #18889

Let's find out if the gce-project pool in k8s-infra-prow-build meets the needs of these jobs.

Fixing grpc variant directly (ref: #18853 (comment)). If this works, we should revert #19033

Trying out http-connect variant via a canary (ref: #18904 (review))

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spiffxp spiffxp deleted the drop-project-for-kubernetes-network-proxy-presubmits branch September 1, 2020 03:02
This was referenced Sep 1, 2020
Closed
Closed
Closed
@spiffxp spiffxp mentioned this pull request Jun 17, 2021
Open
55 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hasheddan hasheddan hasheddan approved these changes

@deads2k deads2k Awaiting requested review from deads2k

@lavalamp lavalamp Awaiting requested review from lavalamp

Assignees

@hasheddan hasheddan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.20
Development

Successfully merging this pull request may close these issues.
3 participants
@spiffxp @k8s-ci-robot @hasheddan