Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create ci-kubernetes-build-fast canary job to validate job running in the cluster #19487

Merged
merged 1 commit into from
Oct 9, 2020

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Oct 8, 2020

create duplicate ci-kubernetes-build-fast to run in the k8s-infra-prow-build cluster to validate the execution build

ref: #19484 and kubernetes/kubernetes#95173

/cc @spiffxp Dont know if there is anything else that we need to change, but this is an initial PR, let me know if this is correct.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/jobs area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. labels Oct 8, 2020
@k8s-ci-robot k8s-ci-robot added the sig/testing Categorizes an issue or PR as relevant to SIG Testing. label Oct 8, 2020
Copy link
Member

@spiffxp spiffxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be modified to push to gs://k8s-release-dev instead of gs://kubernetes-release-dev

I'm not sure off the top of my head which flag needs to be set where for this

Copy link
Member

@spiffxp spiffxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggested changes as well

config/jobs/kubernetes/sig-release/kubernetes-builds.yaml Outdated Show resolved Hide resolved
config/jobs/kubernetes/sig-release/kubernetes-builds.yaml Outdated Show resolved Hide resolved
@cpanato
Copy link
Member Author

cpanato commented Oct 9, 2020

@spiffxp thanks for your review and input! I will check how to change that and apply here.

@cpanato
Copy link
Member Author

cpanato commented Oct 9, 2020

@spiffxp done, PTAL

Copy link
Member

@spiffxp spiffxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm
I'm going to assume you've got the flag correct. This will need changes before we can start moving forward, but I'll merge this to get early signal.

- --
- --allow-dup
- --fast
- --release=k8s-release-dev/ci-canary
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll merge this as-is just to see if the job runs successfully, but for followup this should be different bucket / same path. I think what you have here is different bucket / different path

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, followup PR: #19518

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 9, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 9, 2020
@k8s-ci-robot k8s-ci-robot merged commit 9c663ce into kubernetes:master Oct 9, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Oct 9, 2020
@k8s-ci-robot
Copy link
Contributor

@cpanato: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key kubernetes-builds.yaml using file config/jobs/kubernetes/sig-release/kubernetes-builds.yaml

In response to this:

create duplicate ci-kubernetes-build-fast to run in the k8s-infra-prow-build cluster to validate the execution build

ref: #19484 and kubernetes/kubernetes#95173

/cc @spiffxp Dont know if there is anything else that we need to change, but this is an initial PR, let me know if this is correct.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants