Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create ci-kubernetes-build-canary job #19574

Merged
merged 1 commit into from
Oct 27, 2020
Merged

Create ci-kubernetes-build-canary job #19574

merged 1 commit into from
Oct 27, 2020

Conversation

ameukam
Copy link
Member

@ameukam ameukam commented Oct 14, 2020 •
edited
Loading

Create a canary job, duplicate of ci-kubernetes-build that validates it
can run in k8s-infra-prow-build GKE cluster and write to gs://k8s-release-dev.

EDIT:
Ref: #19483
Part of : #18549

Signed-off-by: Arnaud Meukam ameukam@gmail.com

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 14, 2020
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Oct 14, 2020
@ameukam
Copy link
Member Author

ameukam commented Oct 14, 2020

/assign @spiffxp @justaugustus
cc @kubernetes/ci-signal

@ameukam ameukam force-pushed the migrate-job-ci-kubernetes-build branch from 336acfa to 72ac6d5 Compare October 17, 2020 13:02
@ameukam ameukam force-pushed the migrate-job-ci-kubernetes-build branch from 72ac6d5 to b721cdf Compare October 19, 2020 16:48
justaugustus
justaugustus suggested changes Oct 19, 2020
View reviewed changes
Copy link
Member

@justaugustus justaugustus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold a few comments to address re: GCR location and fork annotations before this goes in

config/jobs/kubernetes/sig-release/kubernetes-builds.yaml Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 19, 2020
@justaugustus
Copy link
Member

FYI @kubernetes/release-engineering

@ameukam ameukam force-pushed the migrate-job-ci-kubernetes-build branch from b721cdf to 2198e8a Compare October 20, 2020 14:38
@MushuEE
Copy link
Contributor

MushuEE commented Oct 21, 2020

/cc @MushuEE

cpanato
cpanato approved these changes Oct 23, 2020
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 23, 2020
@ameukam
Create ci-kubernetes-build-canary job
9df304f 
Create a canary job, duplicate of ci-kubernetes-build that validates it
can run in `k8s-infra-prow-build` GKE cluster and write to `gs://k8s-release-dev`.

Use gcr.io/k8s-staging-ci-images instead of gcr.io/kuernetes-ci-images

Signed-off-by: Arnaud Meukam <ameukam@gmail.com>
@ameukam ameukam force-pushed the migrate-job-ci-kubernetes-build branch from 2198e8a to 9df304f Compare October 24, 2020 10:02
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 24, 2020
cpanato
cpanato approved these changes Oct 27, 2020
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 27, 2020
@justaugustus
Copy link
Member

/lgtm
/approve
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 27, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ameukam, cpanato, justaugustus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 27, 2020
@k8s-ci-robot k8s-ci-robot merged commit d6cc5f6 into kubernetes:master Oct 27, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Oct 27, 2020
@k8s-ci-robot
Copy link
Contributor

@ameukam: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key kubernetes-builds.yaml using file config/jobs/kubernetes/sig-release/kubernetes-builds.yaml

In response to this:

Create a canary job, duplicate of ci-kubernetes-build that validates it
can run in k8s-infra-prow-build GKE cluster and write to gs://k8s-release-dev.

EDIT:
Ref: #19483
Part of : #18549

Signed-off-by: Arnaud Meukam ameukam@gmail.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spiffxp spiffxp mentioned this pull request Nov 20, 2020
Closed
@ameukam ameukam deleted the migrate-job-ci-kubernetes-build branch March 7, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justaugustus justaugustus justaugustus requested changes

@spiffxp spiffxp spiffxp left review comments

@cpanato cpanato cpanato approved these changes

@MushuEE MushuEE Awaiting requested review from MushuEE

Assignees

@spiffxp spiffxp

@justaugustus justaugustus

@cpanato cpanato

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.20
Development

Successfully merging this pull request may close these issues.
6 participants
@ameukam @justaugustus @MushuEE @k8s-ci-robot @spiffxp @cpanato