Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

releng: promote ci-kubernetes-build-fast-canary to be the official job #19660

Merged
merged 1 commit into from
Oct 29, 2020
Merged

releng: promote ci-kubernetes-build-fast-canary to be the official job #19660

merged 1 commit into from
Oct 29, 2020

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Oct 22, 2020 •
edited
Loading

  • remove the canary job, the test shows the job is stable running in the new cluster.
  • set the ci-kubernetes-build-fast job to use the new cluster

fixes: #19484
fixes: kubernetes/kubernetes#95173

/cc @spiffxp @justaugustus

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/jobs area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Oct 22, 2020
justaugustus
justaugustus suggested changes Oct 23, 2020
View reviewed changes
Copy link
Member

@justaugustus justaugustus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs

      - --release=k8s-release-dev

after --fast and the testgrid alerts should include release-managers@kubernetes.io for all build jobs.

@cpanato
Copy link
Member Author

cpanato commented Oct 23, 2020

@justaugustus one question, when do I know we need to use the k8s-release-dev bucket ?
will update the PR based on your feedback, thanks!

@cpanato
Copy link
Member Author

cpanato commented Oct 23, 2020

updated :)

@justaugustus
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 29, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, justaugustus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 29, 2020
@k8s-ci-robot k8s-ci-robot merged commit 046e0d7 into kubernetes:master Oct 29, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Oct 29, 2020
@k8s-ci-robot
Copy link
Contributor

@cpanato: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key kubernetes-builds.yaml using file config/jobs/kubernetes/sig-release/kubernetes-builds.yaml

In response to this:

  • remove the canary job, the test shows the job is stable running in the new cluster.
  • set the ci-kubernetes-build-fast job to use the new cluster

fixes: #19484
fixes: kubernetes/kubernetes#95173

/cc @spiffxp @justaugustus

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cpanato cpanato deleted the GH-19484 branch October 29, 2020 15:27
@mborsz mborsz mentioned this pull request Nov 4, 2020
Closed
@mborsz
Copy link
Member

mborsz commented Nov 4, 2020

Could you comment on the context of using k8s-release-dev? It seems to break some tests including scalability tests (see #19838).

Should we revert this change (k8s-release-dev part) or are you planning to migrate existing jobs to k8s-release-dev bucket?

@justaugustus justaugustus mentioned this pull request Nov 4, 2020
Merged
@spiffxp spiffxp mentioned this pull request Nov 20, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spiffxp spiffxp Awaiting requested review from spiffxp

@justaugustus justaugustus Awaiting requested review from justaugustus

Assignees

@justaugustus justaugustus

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.20
4 participants
@cpanato @justaugustus @k8s-ci-robot @mborsz