-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Add job config to run kubebuilder e2e tests on kubernetes version v1.18.0 #19690
Conversation
Welcome @prafull01! |
Hi @prafull01. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
@camilamacedo86: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
how can we grow your group of approvers to more active contributors? |
/cc @DirectXMan12 @pwittrock |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
I will approve to unblock this time, but backstopping that you have inactive approvers is not our responsibility. Please address that going forward.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, prafull01, spiffxp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@prafull01: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@spiffxp thanks for your help, I mentioned this recently in slack. I think part of the problem is all the kubebuilder projects are in kubernetes-sigs, and not all of the reviewers/approvers over there were k8s org members when we first added the jobs + owners: #17241 (comment) That might be in better shape now, maybe we can add a few more folks. I'm pretty responsive for kubebuilder test-infra even though I haven't been working a ton on KB itself, maybe I can bump myself to approver here for those. @camilamacedo86 I think you should probably be an approver here at least, lmk if you needs k8s org sponsorship or anything. |
Add a kubebuilder job to run e2e tests on kubernetes v1.18.0 version.
Fixes #1743 on kubebuilder