Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add job config to run kubebuilder e2e tests on kubernetes version v1.18.0 #19690

Merged
merged 1 commit into from
Nov 5, 2020

Conversation

prafull01
Copy link
Contributor

Add a kubebuilder job to run e2e tests on kubernetes v1.18.0 version.

Fixes #1743 on kubebuilder

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 26, 2020
@k8s-ci-robot
Copy link
Contributor

Welcome @prafull01!

It looks like this is your first PR to kubernetes/test-infra 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/test-infra has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 26, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @prafull01. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Oct 26, 2020
@alexeldeib
Copy link
Member

/lgtm

@alexeldeib
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 26, 2020
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 26, 2020
Copy link
Contributor

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

@camilamacedo86: changing LGTM is restricted to collaborators

In response to this:

/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@alexeldeib
Copy link
Member

/assign @mengqiy @chases2 (picking on you as a root approver since you've been helpful before and we have a fairly small group of proper approvers 🙂 apologies if that's not proper etiquette).

@spiffxp
Copy link
Member

spiffxp commented Nov 5, 2020

how can we grow your group of approvers to more active contributors?

@spiffxp
Copy link
Member

spiffxp commented Nov 5, 2020

/cc @DirectXMan12 @pwittrock
That's all approvers for kubebuilder assigned to this PR

Copy link
Member

@spiffxp spiffxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm
I will approve to unblock this time, but backstopping that you have inactive approvers is not our responsibility. Please address that going forward.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, prafull01, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 5, 2020
@k8s-ci-robot k8s-ci-robot merged commit b25996e into kubernetes:master Nov 5, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Nov 5, 2020
@k8s-ci-robot
Copy link
Contributor

@prafull01: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key kubebuilder-presubmits.yaml using file config/jobs/kubernetes-sigs/kubebuilder/kubebuilder-presubmits.yaml

In response to this:

Add a kubebuilder job to run e2e tests on kubernetes v1.18.0 version.

Fixes #1743 on kubebuilder

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@prafull01 prafull01 deleted the kubebuilder-e2e-v18 branch November 5, 2020 19:15
@alexeldeib
Copy link
Member

@spiffxp thanks for your help, I mentioned this recently in slack. I think part of the problem is all the kubebuilder projects are in kubernetes-sigs, and not all of the reviewers/approvers over there were k8s org members when we first added the jobs + owners: #17241 (comment)

That might be in better shape now, maybe we can add a few more folks. I'm pretty responsive for kubebuilder test-infra even though I haven't been working a ton on KB itself, maybe I can bump myself to approver here for those.

@camilamacedo86 I think you should probably be an approver here at least, lmk if you needs k8s org sponsorship or anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add prow infra to run the tests in the CI with k8s 1.18
5 participants