-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CAPZ: add "e2e-full" job that includes GPU-based nodes #19715
CAPZ: add "e2e-full" job that includes GPU-based nodes #19715
Conversation
Hi @mboersma. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
27a2cff
to
7561b7d
Compare
testgrid-dashboards: sig-cluster-lifecycle-cluster-api-provider-azure | ||
testgrid-tab-name: pr-e2e | ||
testgrid-alert-email: k8s-infra-staging-cluster-api-azure@kubernetes.io | ||
- name: pull-cluster-api-provider-azure-e2e-full |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is the plan to add this once we've merged the GPU PR and verified the pull job works?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, or the other way around if we prefer. (Although I need to figure out why this failed first.)
The GPU job has passed Prow CI before it was added to GINKGO_SKIP
, so I know it works in general.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you rebased off the latest main branch? Could be #19662
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, I accidentally gave both jobs the same testgrid-tab-name
. Fixed now.
7561b7d
to
7b64f3b
Compare
7b64f3b
to
a47daf9
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: devigned, mboersma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@mboersma: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
kubernetes-sigs/cluster-api-provider-azure#1002 adds a Ginkgo e2e spec to provision and test a GPU-enabled Azure cluster, but skips that test by default. This adds a new
pull-cluster-api-provider-azure-e2e-full
job that can be run on demand to include the GPU-enabled test spec.cc: @CecileRobertMichon @devigned