Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CAPZ: add "e2e-full" job that includes GPU-based nodes #19715

Merged
merged 1 commit into from
Oct 28, 2020

Conversation

mboersma
Copy link
Contributor

kubernetes-sigs/cluster-api-provider-azure#1002 adds a Ginkgo e2e spec to provision and test a GPU-enabled Azure cluster, but skips that test by default. This adds a new pull-cluster-api-provider-azure-e2e-full job that can be run on demand to include the GPU-enabled test spec.

cc: @CecileRobertMichon @devigned

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 27, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @mboersma. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/jobs area/provider/azure Issues or PRs related to azure provider sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Oct 27, 2020
@alexeldeib
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 27, 2020
@mboersma mboersma force-pushed the add-azure-e2e-full-job branch from 27a2cff to 7561b7d Compare October 28, 2020 18:31
testgrid-dashboards: sig-cluster-lifecycle-cluster-api-provider-azure
testgrid-tab-name: pr-e2e
testgrid-alert-email: k8s-infra-staging-cluster-api-azure@kubernetes.io
- name: pull-cluster-api-provider-azure-e2e-full
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the plan to add this once we've merged the GPU PR and verified the pull job works?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, or the other way around if we prefer. (Although I need to figure out why this failed first.)

The GPU job has passed Prow CI before it was added to GINKGO_SKIP, so I know it works in general.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you rebased off the latest main branch? Could be #19662

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I accidentally gave both jobs the same testgrid-tab-name. Fixed now.

@mboersma mboersma force-pushed the add-azure-e2e-full-job branch from 7561b7d to 7b64f3b Compare October 28, 2020 20:36
@mboersma mboersma force-pushed the add-azure-e2e-full-job branch from 7b64f3b to a47daf9 Compare October 28, 2020 20:45
@devigned
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 28, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: devigned, mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 28, 2020
@k8s-ci-robot k8s-ci-robot merged commit 95d2f57 into kubernetes:master Oct 28, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Oct 28, 2020
@k8s-ci-robot
Copy link
Contributor

@mboersma: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key cluster-api-provider-azure-presubmits.yaml using file config/jobs/kubernetes-sigs/cluster-api-provider-azure/cluster-api-provider-azure-presubmits.yaml

In response to this:

kubernetes-sigs/cluster-api-provider-azure#1002 adds a Ginkgo e2e spec to provision and test a GPU-enabled Azure cluster, but skips that test by default. This adds a new pull-cluster-api-provider-azure-e2e-full job that can be run on demand to include the GPU-enabled test spec.

cc: @CecileRobertMichon @devigned

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants