Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubernetes-sigs/kubebuilder: bump existing patch versions, add k8s v1.19.4 #20530

Merged
merged 1 commit into from
Jan 20, 2021
Merged

kubernetes-sigs/kubebuilder: bump existing patch versions, add k8s v1.19.4 #20530

merged 1 commit into from
Jan 20, 2021

Conversation

estroz
Copy link
Contributor

@estroz estroz commented Jan 20, 2021

config/jobs/kubernetes-sigs/kubebuilder: bump patch versions of existing minor versions, add k8s v1.19.4 to presubmit

Signed-off-by: Eric Stroczynski ericstroczynski@gmail.com

@estroz
kubernetes-sigs/kubebuilder: bump patch versions of existing minor ve…
d9db92d 
…rsions, add k8s v1.19.4 to presubmit

Signed-off-by: Eric Stroczynski <ericstroczynski@gmail.com>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 20, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @estroz. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 20, 2021
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jan 20, 2021
@estroz
Copy link
Contributor Author

estroz commented Jan 20, 2021

/assign @DirectXMan12
/cc @pwittrock

@estroz estroz mentioned this pull request Jan 20, 2021
Merged
@camilamacedo86
Copy link
Contributor

/ok-to-test

@k8s-ci-robot
Copy link
Contributor

@camilamacedo86: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pwittrock
Copy link
Member

/ok-to-test
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 20, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 20, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: estroz, pwittrock

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 20, 2021
@k8s-ci-robot k8s-ci-robot merged commit e899ba0 into kubernetes:master Jan 20, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Jan 20, 2021
@k8s-ci-robot
Copy link
Contributor

@estroz: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key kubebuilder-presubmits.yaml using file config/jobs/kubernetes-sigs/kubebuilder/kubebuilder-presubmits.yaml

In response to this:

config/jobs/kubernetes-sigs/kubebuilder: bump patch versions of existing minor versions, add k8s v1.19.4 to presubmit

Signed-off-by: Eric Stroczynski ericstroczynski@gmail.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@estroz estroz deleted the chore/bump-k8s-versions-kb branch January 20, 2021 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexeldeib alexeldeib Awaiting requested review from alexeldeib

@DirectXMan12 DirectXMan12 Awaiting requested review from DirectXMan12

@pwittrock pwittrock Awaiting requested review from pwittrock

Assignees

@DirectXMan12 DirectXMan12

@pwittrock pwittrock

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@estroz @k8s-ci-robot @camilamacedo86 @pwittrock @DirectXMan12